Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support lib.cc #1035

Merged
merged 33 commits into from
Dec 16, 2024
Merged

build: support lib.cc #1035

merged 33 commits into from
Dec 16, 2024

Conversation

Lazauya
Copy link
Contributor

@Lazauya Lazauya commented Nov 14, 2024

A simple implementation for static library building. It functions nearly identically to executable building, except that we look for files named lib.cc (or the other acceptable C++ extensions) and resolved the dependencies for that file. Instead of linking everything into an executable at the end, we instead use ar to build an object archive called lib<package-name>.a.

@Lazauya Lazauya marked this pull request as ready for review November 14, 2024 04:29
src/BuildConfig.cc Outdated Show resolved Hide resolved
@ken-matsui
Copy link
Member

Please fix CI errors.

@Lazauya
Copy link
Contributor Author

Lazauya commented Nov 15, 2024

Please fix CI errors.

Working on it! I think I know what the issue is, luckily.

src/BuildConfig.hpp Outdated Show resolved Hide resolved
@ken-matsui
Copy link
Member

Please fix CI errors.

Working on it! I think I know what the issue is, luckily.

Great, thanks!

@ken-matsui
Copy link
Member

ken-matsui commented Nov 16, 2024

Please fix conflicts. (Note: this was merged)

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LG. Let's address some small things. Thanks!

src/BuildConfig.cc Outdated Show resolved Hide resolved
src/Cmd/Build.cc Outdated Show resolved Hide resolved
@ken-matsui ken-matsui changed the title Library building build: support lib.cc Nov 16, 2024
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more comments but don't have enough time. Let me do that later. Here's what I have so far.

src/Cmd/Build.cc Outdated Show resolved Hide resolved
src/BuildConfig.cc Outdated Show resolved Hide resolved
src/BuildConfig.cc Outdated Show resolved Hide resolved
src/BuildConfig.cc Outdated Show resolved Hide resolved
src/Cmd/Build.cc Outdated Show resolved Hide resolved
src/Cmd/Build.cc Outdated Show resolved Hide resolved
@ken-matsui
Copy link
Member

Please fix conflicts, thank you

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking long to review!

src/BuildConfig.cc Outdated Show resolved Hide resolved
src/BuildConfig.cc Outdated Show resolved Hide resolved
src/BuildConfig.cc Show resolved Hide resolved
src/BuildConfig.cc Outdated Show resolved Hide resolved
src/BuildConfig.cc Outdated Show resolved Hide resolved
src/BuildConfig.hpp Outdated Show resolved Hide resolved
src/BuildConfig.hpp Outdated Show resolved Hide resolved
src/BuildConfig.hpp Outdated Show resolved Hide resolved
src/BuildConfig.hpp Outdated Show resolved Hide resolved
src/Cmd/Build.cc Outdated Show resolved Hide resolved
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Just small performance tweaks, and then LG. Thanks!

src/BuildConfig.hpp Outdated Show resolved Hide resolved
src/Cmd/Build.cc Outdated Show resolved Hide resolved
@ken-matsui ken-matsui merged commit 2e0da2c into cabinpkg:main Dec 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants