-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: support lib.cc #1035
build: support lib.cc #1035
Conversation
Please fix CI errors. |
Working on it! I think I know what the issue is, luckily. |
Great, thanks! |
Please fix conflicts. (Note: this was merged) |
# Conflicts: # src/BuildConfig.cc # src/Cmd/Build.cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LG. Let's address some small things. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have more comments but don't have enough time. Let me do that later. Here's what I have so far.
Please fix conflicts, thank you |
…ding # Conflicts: # src/BuildConfig.cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking long to review!
…ecomes liblibpoac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. Just small performance tweaks, and then LG. Thanks!
A simple implementation for static library building. It functions nearly identically to executable building, except that we look for files named
lib.cc
(or the other acceptable C++ extensions) and resolved the dependencies for that file. Instead of linking everything into an executable at the end, we instead usear
to build an object archive calledlib<package-name>.a
.