-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: support path dependencies #1048
manifest: support path dependencies #1048
Conversation
cec12cf
to
c8874a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. This looks nice code-wise, but let’s address 2 things:
- Use path instead of local (https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-path-dependencies)
- Follow CONTRIBUTING.md, especially Documentation, Commit Message, and Pull Request Style.
done.
What exactly will I need to do?
|
59f6275
to
8400fcc
Compare
You can update the documentation without mentioning It's not mandatory to update each commit message, but improving future messages saves me tons of time keeping track of progression. Can you follow this for the PR title and description? This documentation is meant to be reviewed before creating a PR, as the PR title and description are generated from the commit message. |
You mean to bring back the description to edit
I've thought what the description doesn't contain, and I've realized the description doesn't explain what is path dependency and how it behave. I'll add some description about it. |
Yes, whichever
The key point for the PR title is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR introduces path dependency like Cargo's one.
Path dependency specify a local directory as dependency.
Unlike Cargo's one,
poac.toml
in the path.version
for published package.This PR doesn't contain
poac add --path
sub-command option.Poac with this PR can allow
poac.toml
like below: