Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: support cpplint 2.0 #1049

Merged
merged 1 commit into from
Dec 23, 2024
Merged

lint: support cpplint 2.0 #1049

merged 1 commit into from
Dec 23, 2024

Conversation

wx257osn2
Copy link
Contributor

Current poac code fails poac lint with cpplint 2.0.0. This PR fixes this:

$ cpplint --version
Cpplint fork (https://github.com/cpplint/cpplint)
cpplint 2.0.0
Python 3.12.3 (main, Nov  6 2024, 18:32:19) [GCC 13.2.0]
$ poac-out/debug/poac lint --exclude srcOld --exclude testsOld
   Linting poac
src/BuildConfig.cc:19:  <filesystem> is an unapproved C++17 header.  [build/c++17] [5]
Done processing src/BuildConfig.cc
src/Command.cc:235:  Add #include <string> for string  [build/include_what_you_use] [4]
Done processing src/Command.cc
src/Command.hpp:4:  <filesystem> is an unapproved C++17 header.  [build/c++17] [5]
Done processing src/Command.hpp
src/Rustify/Aliases.hpp:4:  <filesystem> is an unapproved C++17 header.  [build/c++17] [5]
Done processing src/Rustify/Aliases.hpp
Total errors found: 4
Error: 'poac lint' failed with exit code `1`

@ken-matsui ken-matsui changed the title fix for cpplint 2.0 lint: support cpplint 2.0 Dec 23, 2024
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ken-matsui ken-matsui merged commit bc9c3df into cabinpkg:main Dec 23, 2024
18 checks passed
@wx257osn2 wx257osn2 deleted the fix-cpplint branch December 23, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants