Skip to content

Incompatible with Caddy 2.7.0-beta #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cdn0x12 opened this issue Jun 30, 2023 · 1 comment · Fixed by #32
Closed

Incompatible with Caddy 2.7.0-beta #31

cdn0x12 opened this issue Jun 30, 2023 · 1 comment · Fixed by #32

Comments

@cdn0x12
Copy link

cdn0x12 commented Jun 30, 2023

Running xcaddy build v2.7.0-beta.2 --with github.com/caddyserver/nginx-adapter will not produce a successful build.

Logs:

2023/06/30 02:58:24 [INFO] exec (timeout=-2562047h47m16.854775808s): /usr/local/go/bin/go build -o /workspaces/nginx-adapter/caddy -ldflags -w -s -trimpath 
# github.com/caddyserver/nginx-adapter
/go/pkg/mod/github.com/caddyserver/[email protected]/server.go:231:4: unknown field WriterRaw in struct literal of type caddy.CustomLog
2023/06/30 02:59:14 [INFO] Cleaning up temporary folder: /tmp/buildenv_2023-06-30-0257.2300610627
2023/06/30 02:59:14 [FATAL] exit status 1
@mholt
Copy link
Member

mholt commented Jun 30, 2023

Thanks for the report! This is from caddyserver/caddy#5441. We'll get this fixed as soon as possible. (Or, pull request welcomed.)

mohammed90 added a commit that referenced this issue Jul 7, 2023
@mohammed90
bug: fix compatibility with latest caddy
c1ec199 
Caddy v2.7.0-beta introduces the ability to customize the sink logs. This comes at the cost of changing the way Go structs are initialized. This change updates our Caddy plugin to be compatible with the latest changes.

Fixes #31
@mohammed90 mohammed90 mentioned this issue Jul 7, 2023
Merged
mohammed90 added a commit that referenced this issue Jul 7, 2023
@mohammed90
bug: fix compatibility with latest caddy (#32)
e1190e7 
Caddy v2.7.0-beta introduces the ability to customize the sink logs. This comes at the cost of changing the way Go structs are initialized. This change updates our Caddy plugin to be compatible with the latest changes.

Fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: fix compatibility with latest caddy caddyserver/nginx-adapter
2 participants
@mholt @cdn0x12