Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module: ML Infra Projects #5

Closed
wants to merge 40 commits into from
Closed

Conversation

caetano-colin
Copy link
Owner

No description provided.

@caetano-colin caetano-colin marked this pull request as ready for review May 10, 2024 17:51
@daniel-cit
Copy link

Check the output for diffs and correct using terraform fmt

@caetano-colin
Copy link
Owner Author

Check the output for diffs and correct using terraform fmt

What do you mean by "diffs"?

About terraform fmt:

I opened a PR to fix the build error:
GoogleCloudPlatform#39

When merging these changes to this branch, build is green:
be0ba50

I reverted the change above on this PR to keep the scope closed, as you can see in commit
38069e2

Copy link

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor fixes

4-projects/modules/ml_single_project/main.tf Outdated Show resolved Hide resolved
4-projects/modules/ml_single_project/main.tf Outdated Show resolved Hide resolved
4-projects/modules/ml_single_project/outputs.tf Outdated Show resolved Hide resolved
4-projects/modules/ml_single_project/outputs.tf Outdated Show resolved Hide resolved
4-projects/modules/ml_single_project/variables.tf Outdated Show resolved Hide resolved
4-projects/modules/ml_infra_projects/variables.tf Outdated Show resolved Hide resolved
4-projects/modules/ml_infra_projects/variables.tf Outdated Show resolved Hide resolved
4-projects/modules/ml_infra_projects/variables.tf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants