Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for Linux, Windows and Darwin #26

Open
Tracked by #75
caffeine-addictt opened this issue Apr 28, 2024 · 11 comments · Fixed by #30
Open
Tracked by #75

Testing for Linux, Windows and Darwin #26

caffeine-addictt opened this issue Apr 28, 2024 · 11 comments · Fixed by #30
Assignees
Labels
help wanted Help wanted Type: Test A problem or enhancement related to a test.

Comments

@caffeine-addictt
Copy link
Owner

caffeine-addictt commented Apr 28, 2024

Testing for the 3 major OSes (Linux, Windows & Darwin).
PR welcome

Track

@caffeine-addictt caffeine-addictt added help wanted Help wanted Type: Test A problem or enhancement related to a test. labels Apr 28, 2024
@caffeine-addictt caffeine-addictt self-assigned this Apr 28, 2024
@caffeine-addictt caffeine-addictt pinned this issue Apr 28, 2024
caffeine-addictt added a commit that referenced this issue Apr 28, 2024
caffeine-addictt added a commit that referenced this issue Apr 28, 2024
@caffeine-addictt caffeine-addictt added the Status: Waiting Waiting on something else to be ready. label Apr 28, 2024
@caffeine-addictt caffeine-addictt linked a pull request Apr 29, 2024 that will close this issue
12 tasks
@caffeine-addictt caffeine-addictt added Status: WIP Currently being worked on. and removed Status: Waiting Waiting on something else to be ready. labels Apr 29, 2024
@caffeine-addictt caffeine-addictt added this to the v1.9.0 milestone Apr 29, 2024
@caffeine-addictt caffeine-addictt mentioned this issue Apr 29, 2024
13 tasks
@caffeine-addictt
Copy link
Owner Author

@LyubomirT Any idea on how to optimize in node?

ReadFileSync writes the contents of each file into memory, but i believe it would be better to implement this with streams. I haven't been successful so far though...

You can see the failed implementation merged in #36

@LyubomirT
Copy link
Contributor

Streaming actually sounds like a great idea, I'll see what I can do and will try to add the implementation to my fork if I succeed. Can't guarantee anything for now, though.

@LyubomirT
Copy link
Contributor

Any idea on how to optimize in node?

However, personally, I don't think optimization will matter much here, since all the files combined likely won't eat more than 10KB of memory.

@caffeine-addictt
Copy link
Owner Author

Any idea on how to optimize in node?

However, personally, I don't think optimization will matter much here, since all the files combined likely won't eat more than 10KB of memory.

True. Although apart from a lower memory usage, we would be able to boost runtime performance.

@caffeine-addictt
Copy link
Owner Author

Alright.
I got it stable in Archlinux after #38. 🥳

Is it working fine on your side?

@LyubomirT
Copy link
Contributor

Alright.
I got it stable in Archlinux after #38. 🥳

Is it working fine on your side?

Glad to hear it works well! Can't really use it in Windows 11 for some reason, but maybe it's just the merge conflict.

@caffeine-addictt
Copy link
Owner Author

Perhaps your fork is outdated? 🤔

@LyubomirT
Copy link
Contributor

LyubomirT commented Apr 30, 2024

Perhaps your fork is outdated? 🤔

It was indeed outdated, but due to how late I noticed that, I got a merge conflict, and, well, it all got broken.

===

I managed to get your version to work, though :D

@caffeine-addictt caffeine-addictt modified the milestones: v1.9.0, v1.10.0 May 1, 2024
@caffeine-addictt caffeine-addictt removed the Status: WIP Currently being worked on. label May 1, 2024
@caffeine-addictt
Copy link
Owner Author

I'll hold off on writing tests until I've added a few more features. PRs still welcome though ❤️

@caffeine-addictt
Copy link
Owner Author

Any idea on how to optimize in node?

However, personally, I don't think optimization will matter much here, since all the files combined likely won't eat more than 10KB of memory.

True. Although apart from a lower memory usage, we would be able to boost runtime performance.

@LyubomirT lets move this to #46 :>

@caffeine-addictt caffeine-addictt removed this from the v1.10.0 milestone May 7, 2024
@caffeine-addictt caffeine-addictt unpinned this issue Aug 9, 2024
@caffeine-addictt
Copy link
Owner Author

Including this is v2 in Go.

For v2, I think it'd be great if we had some blackbox testing with docker and bash too.
@LyubomirT lmk if you're still up for it! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Help wanted Type: Test A problem or enhancement related to a test.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants