From 94d57d9fd6c8b041faf693592a3c3b72d277119a Mon Sep 17 00:00:00 2001 From: Kevin Pfeifer Date: Fri, 4 Jul 2025 16:13:46 +0200 Subject: [PATCH 1/3] fix error with change in slevomat/coding-standard 8.19.0 --- CakePHP/Sniffs/Classes/ReturnTypeHintSniff.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CakePHP/Sniffs/Classes/ReturnTypeHintSniff.php b/CakePHP/Sniffs/Classes/ReturnTypeHintSniff.php index 9f1764c..699115c 100644 --- a/CakePHP/Sniffs/Classes/ReturnTypeHintSniff.php +++ b/CakePHP/Sniffs/Classes/ReturnTypeHintSniff.php @@ -230,7 +230,7 @@ protected function getClassNameWithNamespace(File $phpCsFile): ?string return ClassHelper::getFullyQualifiedName( $phpCsFile, - $phpCsFile->findPrevious(TokenHelper::$typeKeywordTokenCodes, $lastToken) + $phpCsFile->findPrevious([T_CLASS, T_TRAIT, T_INTERFACE, T_ENUM], $lastToken) ); } } From 27c1ece16253f04b0f917a9fda43efddee5e6930 Mon Sep 17 00:00:00 2001 From: Kevin Pfeifer Date: Fri, 4 Jul 2025 16:17:37 +0200 Subject: [PATCH 2/3] fix CI --- .github/workflows/ci.yml | 50 ++++++++-------------------------------- 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 92cbce0..29190d1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,11 +14,13 @@ jobs: strategy: fail-fast: false matrix: - php-version: ['7.2', '7.4', '8.0'] - prefer-lowest: [''] + php-version: ['7.2', '7.4'] + dependencies: [highest] include: - php-version: '7.2' - prefer-lowest: 'prefer-lowest' + dependencies: 'lowest' + - php-version: '8.0' + composer-options: "--ignore-platform-reqs" steps: - uses: actions/checkout@v2 @@ -30,29 +32,11 @@ jobs: extensions: mbstring, intl coverage: pcov - - name: Get composer cache directory - id: composer-cache - run: echo "::set-output name=dir::$(composer config cache-files-dir)" - - - name: Get date part for cache key - id: key-date - run: echo "::set-output name=date::$(date +'%Y-%m')" - - - name: Cache composer dependencies - uses: actions/cache@v1 + - name: Composer install + uses: ramsey/composer-install@v3 with: - path: ${{ steps.composer-cache.outputs.dir }} - key: ${{ runner.os }}-composer-${{ steps.key-date.outputs.date }}-${{ hashFiles('composer.json') }}-${{ matrix.prefer-lowest }} - - - name: Composer Install - run: | - if [[ ${{ matrix.php-version }} == '8.0' ]]; then - composer install --ignore-platform-reqs - elif ${{ matrix.prefer-lowest == 'prefer-lowest' }}; then - composer update --prefer-lowest --prefer-stable - else - composer install - fi + dependency-versions: ${{ matrix.dependencies }} + composer-options: "${{ matrix.composer-options }}" - name: Setup problem matchers for PHPUnit if: matrix.php-version == '7.4' @@ -82,22 +66,8 @@ jobs: tools: cs2pr coverage: none - - name: Get composer cache directory - id: composer-cache - run: echo "::set-output name=dir::$(composer config cache-files-dir)" - - - name: Get date part for cache key - id: key-date - run: echo "::set-output name=date::$(date +'%Y-%m')" - - - name: Cache composer dependencies - uses: actions/cache@v1 - with: - path: ${{ steps.composer-cache.outputs.dir }} - key: ${{ runner.os }}-composer-${{ steps.key-date.outputs.date }}-${{ hashFiles('composer.json') }}-${{ matrix.prefer-lowest }} - - name: Composer install - run: composer install + uses: ramsey/composer-install@v3 - name: Run PHP CodeSniffer run: vendor/bin/phpcs --report=checkstyle CakePHP/ | cs2pr From dc83ea8b08b74f1d656eddede14c09c26ad8ce1d Mon Sep 17 00:00:00 2001 From: Kevin Pfeifer Date: Fri, 4 Jul 2025 16:45:26 +0200 Subject: [PATCH 3/3] fix CS warnings using deprecated configs --- CakePHP/ruleset.xml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/CakePHP/ruleset.xml b/CakePHP/ruleset.xml index c5dba13..5ad9111 100644 --- a/CakePHP/ruleset.xml +++ b/CakePHP/ruleset.xml @@ -51,10 +51,15 @@ */tests/* - + + + + + + @@ -81,7 +86,6 @@ -