Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support via json #29

Open
haunt98 opened this issue Jul 6, 2023 · 7 comments
Open

Feature request: Support via json #29

haunt98 opened this issue Jul 6, 2023 · 7 comments

Comments

@haunt98
Copy link

haunt98 commented Jul 6, 2023

For example I have via layout as define here: https://gist.github.com/haunt98/d1210e625c2bf021d9a59f84ef822f9f

Is there a plan to support via in the future?

@caksoylar
Copy link
Owner

It is something on my list, although the priority is low given:

  • VIA already visualizes the keymap itself (although not all layers at once unless they added a print option?)
  • qmk via2json can (in theory) be used to convert the keymap to the QMK json keymap format keymap-drawer can parse

I would be open to having it in the repo and having feedback e.g. in the form of an issue like this one helps, so thanks for opening.

(Note to self, I should refactor the parse module to split it up further since it will get unwieldy if we add more parsers.)

@haunt98
Copy link
Author

haunt98 commented Jul 6, 2023

Thanks @caksoylar for quick reply.
TIL about qmk via2json, let me try that first.
VIA already show image, but can not export or generate it programmatically, I want to explore more things before come back screenshot my VIA layout :D
Also feel free to close this issue if you want.
Many thanks.

@caksoylar
Copy link
Owner

I'll keep it open since it is eventually planned. I'd appreciate if you let me know how it goes with qmk via2json!

@haunt98
Copy link
Author

haunt98 commented Jul 18, 2023

Sorry for late reply, but it works!

So I run qmk via2json with my gist via layout json:

qmk via2json -kb dztech/dz60rgb_wkl/v2 dz60rgb_wkl_v2.layout.json -o qmk.json

Then upload to your website as you can see here

image

@caksoylar
Copy link
Owner

Thank you for the update! Since it is confirmed to work, I'll expand the README to add an example command like yours.

@haunt98
Copy link
Author

haunt98 commented Jul 22, 2023

Thanks @caksoylar

@caksoylar
Copy link
Owner

I will drop a link to https://github.com/YAL-Tools/vial-to-keymap-drawer here, which supports Vial and VIA files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants