Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromStringArray method is not working as expected #786

Open
tiaguinhor opened this issue Dec 15, 2020 · 0 comments
Open

fromStringArray method is not working as expected #786

tiaguinhor opened this issue Dec 15, 2020 · 0 comments

Comments

@tiaguinhor
Copy link

Hey guys, I'm using the up to date calcinai 2.2.4 but the fromStringArray method from Model class is not working as expected.

When passing the second argument as true, it should override all the values as the previous versions (Calcinai 1), but that method is only changing _data and not _dirty as well, so it's not impacted on the API.
image

If you check any setter, the methods are calling propertyUpdated for updating the _dirty property and then the _data:
image

So updating the Model for doing the same, solved the problem and worked like the previous versions:
image

Right now we are overriding that method in our own class, but hope it helps others and also a fix could be released soon for that.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant