Many entries in the Open source licenses page are followed by null #324
Assignees
Labels
bug
Something isn't working
Comments
|
I see the problem.... I don't know if it is worth fixing as I wanted to rewrite that part anyways (see #303) |
|
It can be pending if it is rewriting. |
Merged
Leptopoda
added a commit
that referenced
this issue
Oct 18, 2021
Leptopoda
added a commit
that referenced
this issue
Oct 18, 2021
- migrate the `open source license page`to `showLicensePage()` - deactivate unused buildrunner ## Why? this method is flutter internal. This means less code to maintain and less issues to make (see the one this fixes). ## What changes? - a bit of UI (the new page will have a master detail view on large screens helping accessibility) - we don't need to pre generate the licenses manually
Leptopoda
added a commit
that referenced
this issue
Oct 18, 2021
- migrate the `open source license page`to `showLicensePage()` - deactivate unused buildrunner ## Why? this method is flutter internal. This means less code to maintain and less issues to make (see the one this fixes). ## What changes? - a bit of UI (the new page will have a master detail view on large screens helping accessibility) - we don't need to pre generate the licenses manually
Leptopoda
added a commit
that referenced
this issue
Oct 18, 2021
- migrate the `open source license page`to `showLicensePage()` - deactivate unused buildrunner ## Why? this method is flutter internal. This means less code to maintain and less issues to make (see the one this fixes). ## What changes? - a bit of UI (the new page will have a master detail view on large screens helping accessibility) - we don't need to pre generate the licenses manually
Leptopoda
added a commit
that referenced
this issue
Oct 18, 2021
- migrate the `open source license page`to `showLicensePage()` - deactivate unused buildrunner ## Why? this method is flutter internal. This means less code to maintain and less issues to make (see the one this fixes). ## What changes? - a bit of UI (the new page will have a master detail view on large screens helping accessibility) - we don't need to pre generate the licenses manually
|
Fixed. 8459d36 Just because of the format of the Commit Subject, this issue is not automatically closed. Maybe the |
|
as said in my comment
this is completely normal and a wanted behavior. Now someone could report the issue (thinking it is not know) only because the fix isn't released yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many entries in the Open source licenses page are followed by
null.I verified tag v1.1.38 (a5dfe51), there is no such problem.
This issue is most likely related to #284.
It is a low-priority issue, but it would be best to fix it before v1.2.0 is released.
The text was updated successfully, but these errors were encountered: