Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3939] fix org banner #15456

Open
PeerRich opened this issue Jun 17, 2024 · 7 comments · May be fixed by #15557
Open

[CAL-3939] fix org banner #15456

PeerRich opened this issue Jun 17, 2024 · 7 comments · May be fixed by #15557
Labels
🙋🏻‍♂️help wanted Help from the community is appreciated Low priority Created by Linear-GitHub Sync organizations area: organizations, orgs ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input

Comments

@PeerRich
Copy link
Member

PeerRich commented Jun 17, 2024

before:

image

after:
CleanShot 2024-06-17 at 14 10 42@2x

CAL-3939

@PeerRich PeerRich changed the title fix org banner [CAL-3939] fix org banner Jun 17, 2024
@PeerRich PeerRich added 🙋🏻‍♂️help wanted Help from the community is appreciated ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work Low priority Created by Linear-GitHub Sync organizations area: organizations, orgs labels Jun 17, 2024
@PeerRich PeerRich added this to the v4.3 milestone Jun 17, 2024
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Jun 17, 2024
@PeerRich PeerRich modified the milestones: v4.3, Community Only Jun 17, 2024
@gaurab-khanal
Copy link

@PeerRich Can I work on this?

@Ayush9026
Copy link

/assign i will solve this.

@theashishmaurya
Copy link

@PeerRich let me know if i can solve this issue

@Preetam078
Copy link

Hello @PeerRich Hi have implemented the UI as per the Requirement
Here is the Screenshot Below
Screenshot 2024-06-18 at 1 39 11 AM

But What about The FallbackImage for the New Banner Avatar, Currently I am Dealing with the same Fallback Image as it is used in the Avatar Component, Here is the Screenshot Below
Screenshot 2024-06-18 at 1 39 21 AM

Suggestion: We also need to create a new Shimmer UI for the Banner Avatar, Currently we are dealing with the Avatar Shimmer only, Here is the ScreenShot

Screenshot 2024-06-18 at 1 26 42 AM

@theashishmaurya
Copy link

Hi @Preetam078 How you were able to access the organization? Because as of now I'm not able to enable it using the env.

codexsusan added a commit to codexsusan/cal.com that referenced this issue Jun 18, 2024
@codexsusan codexsusan mentioned this issue Jun 18, 2024
2 tasks
@Preetam078
Copy link

Preetam078 commented Jun 19, 2024

HI @PeerRich, @sean-brydon is there any update on handling the Fallback Image in the New Banner UI, as I completed the whole development, just need a clarification on Fallback Image handling.

@PeerRich
Copy link
Member Author

fallback? if no image is uploaded, dont show it

@panzacoder panzacoder linked a pull request Jun 25, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋🏻‍♂️help wanted Help from the community is appreciated Low priority Created by Linear-GitHub Sync organizations area: organizations, orgs ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
5 participants