Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events from CalDAV not taken into consideration when checking availability #624

Closed
kuba-orlik opened this issue Sep 9, 2021 · 26 comments
Closed
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@kuba-orlik
Copy link
Contributor

kuba-orlik commented Sep 9, 2021

Issue Summary

Appointment selector shows me as available even if I have a single day-long event for a particular date

Steps to Reproduce

  1. Connect a CalDAV server
  2. Pick a calendar & confirm
  3. In a calendar app, create an event for a given date
  4. Open the URL of meeting time picker
  5. Select the day containing the event from step 3
  6. See that all possible time slots are available, not affected by the event created in step 3

Technical details

  • Browser version: Firefox 92
  • Node.js version: 14
@femyeda
Copy link

femyeda commented Sep 9, 2021

Fixed in latest commit. Will let you know when deployed.

@jdaviescoates
Copy link

Really looking forward to this being deployed! I'm really loving Cal.com so far, but without CalDAV working properly I can't use it because my Nextcloud CalDAV calendar is my primary calendar.

@Kovah
Copy link

Kovah commented Nov 9, 2021

Is there any ETA when this will be deployed? It's basically the only issue holding me back from using Cal right now. :(

@jdaviescoates
Copy link

@Kovah it looks like there are quite a few CalDAV issues that need resolving see #956 - but I'm the same as you, as soon as CalDAV integration actually works I'll start using Cal :)

@natelindev
Copy link
Contributor

cannot repoduce this now.

@jdaviescoates
Copy link

cannot repoduce this now.

Nor can I. Just tested on cal.com and it does now block out times from my CalDAV calendar!

@femyeda femyeda removed their assignment Dec 14, 2021
@obstschale
Copy link

I just signed up on cal.com and connected my CalDAV Account. This bug is still present.

@jdaviescoates
Copy link

I just signed up on cal.com and connected my CalDAV Account. This bug is still present.

Works for me using Nextcloud Calendar. What CalDAV are you using @obstschale ?

@borishinzer
Copy link

Same issue here. Tested with Nextcloud 19 and 23

@obstschale
Copy link

obstschale commented Jan 13, 2022

I use Synology Calendar. I use CalDav on my MacBook, Android Devices and have no problem at all.

The screenshot shows that I have 1 meeting, but cal.com offers free slots
CleanShot 2022-01-13 at 17 16 37

@amigasoc
Copy link

If it's significant, we're seeing this in our logs:

timeZoneName WARN [[lib] caldav_calendar Method not implemented. dateFrom: 2022-02-24T00:00:00+00:00, dateTo: 2022-02-24T23:59:59+00:00, selectedCalendars: [object Object]

We're connecting to a CalDAV server on Radicale.

@mathieugp
Copy link

I am seeing this problem too. My CalDav compatible server is NextCloud 20.x.

One difference maybe with the other cases above: for some reason, one particular event seems to be taken into account. That event was created by accepting an invitation sent from Google Calendar to my CalDav calendar, while the others were created by me manually. I am using Thunderbird 78.x on Ubuntu 20.04 on the client side.

I will be happy to share any (non personal) information if it can help. :-)

@KierenB
Copy link

KierenB commented Jan 23, 2022

Commenting to note that I am also seeing this issue - connecting to Fastmail via caldav.

@lionux2
Copy link

lionux2 commented Jan 28, 2022

The same issue with Apple Calendar ... tested today, and failing too.

@ykktrcb7
Copy link

Same issue with Baikal server

@PeerRich
Copy link
Member

has this not fixed the bug? https://github.com/calendso/calendso/pull/1649 if not, @natelindev can take a look!

@jdaviescoates
Copy link

I just re-checked and this works fine for me using a Nextcloud calendar. Events on my Nextcloud calendar are taken into consideration are those time slots are not available to book via Cal.com

@KierenB
Copy link

KierenB commented Feb 4, 2022

I just checked using cal.com, it's not fixed there yet (not sure if the fix has been deployed there yet or not?)

Edit: using Fastmail caldav account

@lionux2
Copy link

lionux2 commented Feb 5, 2022

Just checked and not working for me either. Based on jdaviescoates, it works, so maybe his configuration on Nextcloud calendar works. I have multiple ' calendars', such as personal, work, etc... so maybe cal.com does not go through any of them if many exists?

@PeerRich
Copy link
Member

PeerRich commented Feb 5, 2022

Just checked and not working for me either. Based on jdaviescoates, it works, so maybe his configuration on Nextcloud calendar works. I have multiple ' calendars', such as personal, work, etc... so maybe cal.com does not go through any of them if many exists?

can you record a loom.com and @natelindev can you take a look?

@PeerRich PeerRich moved this to Todo in Cal.com Core Roadmap Feb 8, 2022
@borishinzer
Copy link

from our cal server's /var/log/messages:

Feb 21 14:59:38 cal yarn[3102337]: #033[90m13:59:38.149 timeZoneName #033[39m#033[1m#033[93mWARN#033[39m#033[22m CalendarManager
Feb 21 14:59:38 cal yarn[3102337]: #033[1m#033[97m#033[41m TypeError #033[49m#033[39m#033[22m Only absolute URLs are supported#033[1m#033[4m
Feb 21 14:59:38 cal yarn[3102337]: error stack:#033[24m#033[22m

I would guess Nextcloud and Cal timezones are not matching?

@haccg
Copy link

haccg commented Apr 17, 2022

Tried it with Synlogy CalDav-Server.

Works ONLY with the primary calendar.
All other calendars are not working with the collision check.

If you could fix this, it would be very good.

@restuccia
Copy link

I encounter a similar issue, probably due to time zones as well. My CalDAV server is SOGo 2.3.12.

@jdaviescoates
Copy link

Just checked and not working for me either. Based on jdaviescoates, it works, so maybe his configuration on Nextcloud calendar works. I have multiple ' calendars', such as personal, work, etc... so maybe cal.com does not go through any of them if many exists?

Just to add, I don't have many but it is checking again two separate Nextcloud calendars (my primary work and personal calendars). And it's still working nicely for me (just checked again - seems to have got a lot faster too). I'm currently on Nextcloud 24.0.1

@jdaviescoates
Copy link

And it's still working nicely for me (just checked again - seems to have got a lot faster too). I'm currently on Nextcloud 24.0.1

Well, it works in that CalDAV events are taken into consideration, and appointments created via Cal.com to added to the calendar selected in the options under https://app.cal.com/apps/installed

However, if I e.g. edit the location of the booking then instead of editing the previously created event a whole new event is added to the calendar. I guess I should create a new issue about that...

@alishaz-polymath
Copy link
Member

@jdaviescoates Yes, please create a new issue about that. I'm going ahead and closing this ticket as I have tested that CalDAV events are taken into consideration to block double booking, as you have confirmed as well. 🙏

Repository owner moved this from Todo to Done in Cal.com Core Roadmap Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests