Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise OMOP mappings with boomer or a boomer-like approach? #72

Open
matentzn opened this issue Jul 28, 2022 · 1 comment
Open

Harmonise OMOP mappings with boomer or a boomer-like approach? #72

matentzn opened this issue Jul 28, 2022 · 1 comment

Comments

@matentzn
Copy link

Currently, the mappings generated by omop2obo do not respect the semantic constraints of all participating ontologies (which makes some sense because of the significant negative impact on performance).

For example, Malignant melanoma of skin of external auditory canal (disorder) in OMOP is mapped to benign connective and soft tissue neoplasm in MONDO (among more than 1000 others) which is not ideal (unless I made a mistake when reading the omop2obo data), but could be weeded out using approaches from the "ontology merging" community, such as https://github.com/INCATools/boomer.

134294 SubClassOf Nothing

Is there any way to guarantee for the OMOP2OBO mappings that:

  1. applying the mapping does not lead to equivalents cycles involving more than 1 ID from any given ID space in OBO
  2. Merging the mappings with the ontologies does not lead to unsatisfiable classes (like above)
  3. There is a 1:1 mapping table that contains only the "best" mapping for between each OMOP id and OBO ontology?

This is hugely difficult issue,

@callahantiff
Copy link
Owner

Hey @matentzn -- confirming that I saw this and agree that it's a very important issue. Will need a few weeks to properly respond, but it's on my list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants