fix: stretch tabbar to full width (#122)

* fix: stretch tabbar to full width

* fix: use try,catch for loading images

Author: okwasniewski

android/src/main/java/com/rcttabview/RCTTabView.kt

@@ -158,17 +158,22 @@ class ReactBottomNavigationView(context: Context) : BottomNavigationView(context
     itemRippleColor = color
   }
 
-  private fun getDrawable(imageSource: ImageSource): Drawable {
-    // TODO: Check if this can be done using some built-in React Native class
-    val imageRequest = ImageRequestBuilder.newBuilderWithSource(imageSource.uri).build()
-    val dataSource = Fresco.getImagePipeline().fetchDecodedImage(imageRequest, context)
-    val result = DataSources.waitForFinalResult(dataSource) as CloseableReference<CloseableBitmap>
-    val bitmap = result.get().underlyingBitmap
-
-    CloseableReference.closeSafely(result)
-    dataSource.close()
+  private fun getDrawable(imageSource: ImageSource): Drawable? {
+    try {
+      val imageRequest = ImageRequestBuilder.newBuilderWithSource(imageSource.uri).build()
+      val dataSource = Fresco.getImagePipeline().fetchDecodedImage(imageRequest, context)
+      val result = DataSources.waitForFinalResult(dataSource) as CloseableReference<CloseableBitmap>
+      val bitmap = result.get().underlyingBitmap
+
+      CloseableReference.closeSafely(result)
+      dataSource.close()
+
+      return BitmapDrawable(resources, bitmap)
+    } catch (_: Exception) {
+      // Asset doesn't exist
+    }
 
-    return BitmapDrawable(resources, bitmap)
+    return null
   }
 
   override fun onDetachedFromWindow() {

android/src/newarch/RCTTabViewManager.kt

@@ -121,7 +121,8 @@ class RCTTabViewManager(context: ReactApplicationContext) :
     val bottomInset = RCTTabViewImpl.getNavigationBarInset(contextInner)
 
     return YogaMeasureOutput.make(
-      toDIPFromPixel(view.measuredWidth.toFloat()),
+      // TabBar should always stretch to the width of the screen.
+      toDIPFromPixel(width),
       toDIPFromPixel(view.measuredHeight.toFloat() + bottomInset)
     )
   }

android/src/oldarch/RCTTabViewManager.kt

@@ -143,7 +143,8 @@ class RCTTabViewManager(context: ReactApplicationContext) : SimpleViewManager<Re
 
       val navigationBarInset = RCTTabViewImpl.getNavigationBarInset(themedContext)
       tabView.measure(spec, spec)
-      this.mWidth = tabView.measuredWidth
+      // TabBar should always stretch to the width of the screen.
+      this.mWidth = width.toInt()
       this.mHeight = tabView.measuredHeight + navigationBarInset
       this.mMeasured = true