Skip to content
This repository has been archived by the owner on May 8, 2019. It is now read-only.

createBottomTabContainer + similar returning ReasonReact.reactElement seems to be incorrect #17

Open
lewisf opened this issue Dec 28, 2018 · 1 comment

Comments

@lewisf
Copy link

lewisf commented Dec 28, 2018

These seem to be ReasonReact.reactClass? I'm having a hard time using bottom tab navigator into JSX for instance.

This doesn't work

<View>
  <BottomTabNavigator />
</View>

nor does this

<View>
  BottomTabNavigator
</View>
@lewisf lewisf changed the title createBottomTabContainer + similar returning ReasonReact.reactElement is incorrect createBottomTabContainer + similar returning ReasonReact.reactElement seems to be incorrect Dec 28, 2018
@lewisf
Copy link
Author

lewisf commented Dec 28, 2018

For the record, I got this working by changing ReasonReact.reactElement as a return type to ReasonReact.reactClass

and then changing my usage of the Tab module (resulting from TabNavigator.create) to

let make = children =>
  ReasonReact.wrapJsForReason(
    ~reactClass=Tabs.render,
    ~props=Js.Obj.empty(),
    children,
  );

@lewisf lewisf closed this as completed Dec 28, 2018
@lewisf lewisf reopened this Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant