feat(ios): replace --destination with --destinations (#165)

* feat(ios): replace --destination with --destinations

* changeset

Author: thymikee

.changeset/smart-humans-hunt.md

@@ -0,0 +1,5 @@
+---
+'@rnef/plugin-platform-apple': patch
+---
+
+feat(ios): replace --destination with --destinations

README.md

@@ -120,7 +120,8 @@ npx create-rnef-app enterprise
 
    - `--mode` to `--variant` for Android commands
    - `--mode` to `--configuration` for iOS commands
-   - `--buildFolder` to `-build-folder` for iOS commands
+   - `--buildFolder` to `--build-folder` for iOS commands
+   - `--destination` to `--destinations` for iOS commands
    - `--appId` to `--app-id` for Android commands
    - `--appIdSuffix` to `--app-id-suffix` for Android commands
 

packages/plugin-platform-apple/src/lib/commands/build/buildOptions.ts

@@ -13,7 +13,7 @@ export type BuildFlags = {
   device?: string;
   catalyst?: boolean;
   buildFolder?: string;
-  destination?: string;
+  destinations?: string[];
   archive?: boolean;
 };
 
@@ -71,8 +71,10 @@ export const getBuildOptions = ({ platformName }: BuilderCommand) => {
       value: 'build',
     },
     {
-      name: '--destination <string>',
-      description: 'Explicitly extend destination e.g. "arch=x86_64"',
+      name: '--destinations <list>',
+      description:
+        'Explicitly defined destinations e.g. "arch=x86_64". You can also pass a comma separated array e.g. "generic/platform=iphoneos,generic/platform=iphonesimulator"',
+      parse: (val: string) => val.split(','),
     },
     {
       name: '--archive',

packages/plugin-platform-apple/src/lib/commands/build/buildProject.ts

@@ -26,6 +26,42 @@ export const buildProject = async (
     );
   }
 
+  function determineDestinations(): string[] {
+    if (args.destinations != undefined) {
+      return args.destinations;
+    }
+
+    if (args.device && typeof args.device === 'string') {
+      // Check if the device argument looks like a UDID (assuming UDIDs are alphanumeric and have specific length)
+      const isUDID = /^[A-Fa-f0-9-]{25,}$/.test(args.device);
+      if (isUDID) {
+        return [`id=${args.device}`];
+      } else {
+        // If it's a device name
+        return [`name=${args.device}`];
+      }
+    }
+
+    if (args.catalyst) {
+      return ['platform=macOS,variant=Mac Catalyst'];
+    }
+
+    if (udid) {
+      return [`id=${udid}`];
+    }
+
+    if (configuration === 'Debug' || args.device) {
+      return [`generic/platform=${simulatorDest}`];
+    }
+
+    return [`generic/platform=${platformName}`];
+  }
+
+  const destinations = determineDestinations().flatMap((destination) => [
+    '-destination',
+    destination,
+  ]);
+
   const xcodebuildArgs = [
     xcodeProject.isWorkspace ? '-workspace' : '-project',
     xcodeProject.name,
@@ -34,28 +70,7 @@ export const buildProject = async (
     configuration,
     '-scheme',
     scheme,
-    '-destination',
-    (() => {
-      if (args.device && typeof args.device === 'string') {
-        // Check if the device argument looks like a UDID (assuming UDIDs are alphanumeric and have specific length)
-        const isUDID = /^[A-Fa-f0-9-]{25,}$/.test(args.device);
-        if (isUDID) {
-          return `id=${args.device}`;
-        } else {
-          // If it's a device name
-          return `name=${args.device}`;
-        }
-      }
-
-      return args.catalyst
-        ? 'platform=macOS,variant=Mac Catalyst'
-        : udid
-        ? `id=${udid}`
-        : configuration === 'Debug' || args.device
-        ? `generic/platform=${simulatorDest}`
-        : `generic/platform=${platformName}` +
-          (args.destination ? ',' + args.destination : '');
-    })(),
+    ...destinations,
   ];
 
   if (args.archive) {