rock build:android doesn't create cache

[ajanuar]

Hello!

I have tested few times of npx rock build:android without any changes. I also checked on .rock dir, it doesn't create a apk file there. Is this expect for build:android?

Thank you!

[thymikee]

This may be due to our logic for finding build artifacts on android:

rock/packages/platform-android/src/lib/commands/runAndroid/findOutputFile.ts

Lines 6 to 42 in dc4f4a6

	export async function findOutputFile(
	androidProject: AndroidProject,
	tasks: string[],
	device?: string,
	) {
	const { appName, sourceDir } = androidProject;
	const selectedTask = tasks.find(
	(t) =>
	t.startsWith('install') ||
	t.startsWith('assemble') ||
	t.startsWith('bundle'),
	);
	if (!selectedTask) {
	return false;
	}
	// handle if selected task includes build flavour as well, eg. installProductionDebug should create ['production','debug'] array
	const variantFromSelectedTask = selectedTask
	?.replace('install', '')
	?.replace('assemble', '')
	?.replace('bundle', '')
	.split(/(?=[A-Z])/);
	// create path to output file, eg. `production/debug`
	const variantPath = variantFromSelectedTask?.join('/')?.toLowerCase();
	// create output file name, eg. `production-debug`
	const variantAppName = variantFromSelectedTask?.join('-')?.toLowerCase();
	const apkOrBundle = selectedTask?.includes('bundle') ? 'bundle' : 'apk';
	const buildDirectory = `${sourceDir}/${appName}/build/outputs/${apkOrBundle}/${variantPath}`;
	const outputFile = await getInstallOutputFileName(
	appName,
	variantAppName,
	buildDirectory,
	apkOrBundle === 'apk' ? 'apk' : 'aab',
	device,
	);
	return outputFile ? `${buildDirectory}/${outputFile}` : undefined;
	}

Could you let us know what's your build / flavor config, where the APK ends up eventually, and help us improve it?

[ajanuar]

Hi @thymikee , thanks for fast respond. My variant is called releaseStaging.

[ajanuar]

the issue is on these lines.

rock/packages/platform-android/src/lib/commands/runAndroid/findOutputFile.ts

Lines 29 to 31 in dc4f4a6

	const variantPath = variantFromSelectedTask?.join('/')?.toLowerCase();
	// create output file name, eg. `production-debug`
	const variantAppName = variantFromSelectedTask?.join('-')?.toLowerCase();

the logic should be

const variantPath = variantFromSelectedTask?.join('')?.toLowerCase();
const variantAppName = variantFromSelectedTask?.join('')?.toLowerCase();
const buildDirectory = `${sourceDir}/${appName}/build/outputs/${apkOrBundle}/${variantPath}`;

[thymikee]

Can you share how your app/build.gradle looks like?

[thymikee]

I have a WIP branch with a fix here: #608. It's gonna work with your case most likely, but I'd like to make it more robust

[ajanuar]

Hi @thymikee, here is what we have in app/build.gradle.

buildTypes {
        debug {
            applicationIdSuffix ".debug"
            signingConfig signingConfigs.debug
        }
        releaseStaging {
            applicationIdSuffix ".staging"
            signingConfig signingConfigs.debug
            minifyEnabled enableProguardInReleaseBuilds
            shrinkResources enableProguardResourceShrinking
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
            matchingFallbacks = ['release']
        }
        release {
            // Caution! In production, you need to generate your own keystore file.
            // see https://reactnative.dev/react-native/docs/signed-apk-android.
            signingConfig signingConfigs.release
            minifyEnabled enableProguardInReleaseBuilds
            shrinkResources enableProguardResourceShrinking

            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
        }
    }

#605 (comment)
appreciate it, thank you!