Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct width mismatches between memory controller and x_addr0 #1081

Closed
Tracked by #1072
nathanielnrn opened this issue Jul 6, 2022 · 3 comments · Fixed by #1096
Closed
Tracked by #1072

Correct width mismatches between memory controller and x_addr0 #1081

nathanielnrn opened this issue Jul 6, 2022 · 3 comments · Fixed by #1096
Labels
C: FPGA Changes for the FPGA backend

Comments

@nathanielnrn
Copy link
Contributor

No description provided.

@nathanielnrn
Copy link
Contributor Author

Seems like here is the right place to start, need to make sure the widths aren't used elsewhere

@rachitnigam rachitnigam added the C: FPGA Changes for the FPGA backend label Jul 8, 2022
@nathanielnrn
Copy link
Contributor Author

I've made some progress on this and seem to be able to generate parametrically sized brams in a given axi-memory-controller. I still have to correctly wire up the memory controllers to the correct brams but it should be doable.

The thing is, I'm not really happy with my implementation. There is quite a lot of code duplication and it's a pretty hacky way of making things wortk. I was wondering if I should open a draft PR to get some notes from @rachitnigam or @sampsyo (or anyone else) on things before I go any further?

@rachitnigam
Copy link
Contributor

Yeah, draft PR would be a good idea

@nathanielnrn nathanielnrn linked a pull request Jul 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: FPGA Changes for the FPGA backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants