NullPointerException raised when attempting to create a campaign when API key is not set.

[jdennes]

The following code:

Campaigns campaigns = new Campaigns();
CampaignForCreation c = new CampaignForCreation();
c.Name = "Example";
c.Subject = "Example";
c.FromName = "Example";
c.FromEmail = "[email protected]";
c.ReplyTo = "[email protected]";
c.HtmlUrl = URI.create("http://example.com/content.html");
c.ListIDs = new String[] { "listid" };
c.SegmentIDs = new String[] { "" };
String id = campaigns.create("clientid", c);
System.out.printf("Campaign created with ID: %s", id);

Results in:

Exception in thread "main" java.lang.NullPointerException
    at com.createsend.util.JerseyClientImpl.handleErrorResponse(JerseyClientImpl.java:363)
    at com.createsend.util.JerseyClientImpl.post(JerseyClientImpl.java:207)
    at com.createsend.util.JerseyClientImpl.post(JerseyClientImpl.java:195)
    at com.createsend.Campaigns.create(Campaigns.java:106)
    at Tester.main(Tester.java:24)

What should actually happen is this:

Exception in thread "main" com.createsend.util.exceptions.UnauthorisedException: The CreateSend API responded with the following authentication error 50: Must supply a valid HTTP Basic Authorization header
    at com.createsend.util.JerseyClientImpl.handleErrorResponse(JerseyClientImpl.java:363)
    at com.createsend.util.JerseyClientImpl.get(JerseyClientImpl.java:148)
    at com.createsend.util.JerseyClientImpl.get(JerseyClientImpl.java:133)
    at com.createsend.util.JerseyClientImpl.get(JerseyClientImpl.java:107)
    at com.createsend.General.getClients(General.java:88)
    at Tester.main(Tester.java:31)

[jdennes]

The core of the problem here appears to be a problem with Jersey not including the body of the response when a 401 Unauthorized response is received after issuing a POST request (so it's not specific to creating a campaign). GET requests which respond with a 401 Unauthorized appear to be fine.

This can be shown by trying the following.

If you change the com.createsend.util.ErrorDeserialiser.getErrorResponse() method as follows:

public ApiErrorResponse<T> getResponse(ClientResponse response) {
    ParameterizedType type = JerseyClientImpl.getGenericReturnType(this.getClass(), 2);
    String body = response.getEntity(String.class);
    return response.getEntity(new GenericType<ApiErrorResponse<T>>(type));
}

The body variable representing the body of the response will be as expected for GET requests which respond with a 401 Unauthorized, but it will be empty for POST requests which respond with a 401 Unauthorized.

/cc @tobio (any experience with Jersey when originally implementing this library would be appreciated)

[tobio]

@jdennes, I didn't run into anything like that. It might be worth checking out the newer versions of Jersey (seems to be up to 1.9) to see if the behaviour's changed?