Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace slow task assignment extraction code #18

Open
ms705 opened this issue May 27, 2015 · 2 comments
Open

Replace slow task assignment extraction code #18

ms705 opened this issue May 27, 2015 · 2 comments

Comments

@ms705
Copy link
Collaborator

ms705 commented May 27, 2015

The naive task mapping extraction code in quincy_dispatcher.cc is slowing things down at scale (most notably when running the simulator on the full Google trace) since it takes a few seconds to extract the task mappings.

We have an algorithmically superior implementation in Flowlessly, which we should back-port into the Firmament code base, so that all flow solvers benefit from it.

@ms705
Copy link
Collaborator Author

ms705 commented Feb 2, 2016

@ICGog is this actually still an issue? I know that the dispatcher code changed significantly since, but it looks like GetMappings() in SolverDispatcher didn't change substantially. Did your recent scalability and performance improvement work would have hit the inefficient assignment extraction as an issue?

@ICGog
Copy link
Collaborator

ICGog commented Feb 3, 2016

I didn't hit this issue in my scalability tests because I was using Flowlessly which can use its fast assignment algorithm to just return task mappings. However, this is likely to still be a problem if we use other solvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants