Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add support for GS_CAN_FEATURE_GET_STATE and GS_CAN_FEATURE_BERR_REPORTING #154

Open
marckleinebudde opened this issue Jan 9, 2023 · 5 comments
Open

Feature: add support for GS_CAN_FEATURE_GET_STATE and GS_CAN_FEATURE_BERR_REPORTING #154

marckleinebudde opened this issue Jan 9, 2023 · 5 comments

Comments

@marckleinebudde
Copy link
Contributor

marckleinebudde commented Jan 9, 2023 •
edited
Loading

In this issue I want to track implementation of the GS_CAN_FEATURE_GET_STATE and GS_CAN_FEATURE_BERR_REPORTING features.

@jhofstee, do you have some work-in-progress code somewhere? Is the newest code in this branch? https://github.com/jhofstee/candleLight_fw/tree/canbus-state
@marckleinebudde marckleinebudde changed the title Feature: add support for GS_CAN_FEATURE_GET_STATE and GS_CAN_FEATURE_BERR_REPORTING Feature: add support for GS_CAN_FEATURE_GET_STATE and GS_CAN_FEATURE_BERR_REPORTING Jan 9, 2023
@marckleinebudde
Copy link
Contributor Author

As far as I can see in #107 and #119 the error frame generation was cleaned up. I want to make sure that this is merged and no code was forgotten.

@marckleinebudde
Copy link
Contributor Author

In #124 (comment) @jhofstee says his implementation can be rebased to mainline.

@marckleinebudde
Copy link
Contributor Author

FTR: The new features have been documented in #124.

Linux support has been mainlined with torvalds/linux@0c9f92a

@fenugrec
Copy link
Collaborator

I wonder if this could be extended to count dropped frames (RX overflows) ...

@marckleinebudde
Copy link
Contributor Author

marckleinebudde commented Feb 24, 2023 •
edited
Loading

We already have the GS_CAN_FLAG_OVERFLOW to signal a RX overflow to Linux:

candleLight_fw/include/gs_usb.h

Line 83 in 4a1e646

#define GS_CAN_FLAG_OVERFLOW (1<<0)

It's not used in the candlelight FW, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marckleinebudde @fenugrec