Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: consider pulling in ST HAL + CMSIS as submodules instead of local copy #82

Open
fenugrec opened this issue Jan 3, 2022 · 2 comments
Open

RFC: consider pulling in ST HAL + CMSIS as submodules instead of local copy #82

fenugrec opened this issue Jan 3, 2022 · 2 comments
Labels
enhancement

Comments

@fenugrec
Copy link
Collaborator

fenugrec commented Jan 3, 2022 •
edited
Loading

drawback : those repos, even when shallow cloned, are huge. CubeF0 is > 300MB.
But HAL alone, without CMSIS is around 7MB, this one could be acceptable. The CMSIS files probably aren't updated as often as the HAL drivers .
@fenugrec fenugrec mentioned this issue Jan 3, 2022
Closed
@Daniel-Trevitz
Copy link
Contributor

Tiny USB is using:
https://github.com/STMicroelectronics/stm32f0xx_hal_driver.git
https://github.com/STMicroelectronics/stm32f4xx_hal_driver.git
https://github.com/STMicroelectronics/cmsis_device_f0.git
https://github.com/STMicroelectronics/cmsis_device_f4.git

When checked out they are currently 40MiB for the cmsis set, and 20MiB for the stm set.
--depth=1 clone only drops 2MB for a total of 58MiB

Our paired-down version of all 4 combined is 6.8MiB, and includes our cmake support.

@fenugrec
Copy link
Collaborator Author

ah, this could help too :

$ man gitmodules
...
submodule..shallow
When set to true, a clone of this submodule will be performed as a shallow clone (with a history depth of
1) unless the user explicitly asks for a non-shallow clone.

fenugrec added a commit to fenugrec/candleLight_fw that referenced this issue Jan 18, 2023
@fenugrec
STM32 HAL: update and use as submodules instead
7c41fe1 
Will make it easier to track upstream bugfixes. Submodules are
configured with "--depth 1" to make retrieval fast.

Partial fix for GH candle-usb#82

Version bumps :
F0xx : 1.7.5 -> 1.7.6
F4xx : 1.7.13 -> 1.8.1
G0xx : 1.4.5 (no change)
@fenugrec fenugrec mentioned this issue Jan 18, 2023
Draft
2 tasks
fenugrec added a commit to fenugrec/candleLight_fw that referenced this issue Jan 18, 2023
@fenugrec
STM32 HAL: update and use as submodules instead
d3f16a8 
Will make it easier to track upstream bugfixes. Submodules are
configured with "--depth 1" to make retrieval fast.

Partial fix for GH candle-usb#82

Version bumps :
F0xx : 1.7.5 -> 1.7.6
F4xx : 1.7.13 -> 1.8.1
G0xx : 1.4.5 (no change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Daniel-Trevitz @fenugrec