Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't combine when we don't demand complete albums #16

Open
canidae opened this issue May 13, 2009 · 0 comments
Open

don't combine when we don't demand complete albums #16

canidae opened this issue May 13, 2009 · 0 comments
Labels

Comments

@canidae
Copy link
Owner

canidae commented May 13, 2009

it is pointless combining groups if we don't demand complete albums, because all files will be looked up anyways. the problem here is that the class that combines groups (Locutus) doesn't know whether we demand complete albums or not. possible solutions:

  • document that it's pointless and let the user sort it out
  • make the variable that denotes whether we demand complete albums public in Matcher or make a getter
  • fetch the setting in Locutus as well as Matcher

we might want to look more into this. currently we won't lookup files if we've compared the file with an album and the score is high enough when we demand complete albums. if we don't demand complete albums then we'll always look up the file.
is this sane? i think it is, the "only save complete albums" thingy sort of is the difference between "album matching" and "single file matching". it's possible this should be documented well somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant