Merge pull request #36 from canjs/33-helper_getIndex-stable

Fix helpers.index

Author: cherifGsoul

src/helpers.js

@@ -60,21 +60,37 @@ var helpers = {
 		} else if (compare(props, items[items.length - 1]) === 1) {
 			return items.length;
 		}
+
 		var low = 0,
-			high = items.length;
+			high = items.length,
+			range = [];
 
 		// From lodash lodash 4.6.1 <https://lodash.com/>
 		// Copyright 2012-2016 The Dojo Foundation <http://dojofoundation.org/>
 		while (low < high) {
 			var mid = (low + high) >>> 1,
 				item = items[mid],
 				computed = compare(props, item);
-			if (computed === -1) {
+			
+			if (computed === 0) {
+				range.push(item);
+				low++;
+			} else if (computed === -1) {
 				high = mid;
 			} else {
 				low = mid + 1;
 			}
 		}
+		if (range.length > 0) {
+			for (var i = 0; i < range.length; i++) {
+				var itemInRange = range[i],
+					id = canReflect.getSchema(itemInRange).identity[0];
+				if (canReflect.hasOwnKey(props, id) && props[id] === itemInRange[id]) {
+					high = items.indexOf(itemInRange);
+					break;
+				}	
+			}
+		}
 		return high;
 		// bisect by calling sortFunc
 	},

src/types/basic-query-sorting-test.js

@@ -356,3 +356,52 @@ QUnit.test("index uses can-reflect", function(){
     QUnit.deepEqual([obj1Read, obj2Read, itemKeyRead, itemOwnKeyRead],
         [true, true, true, true], "read everything");
 });
+
+
+QUnit.test("index should not sort unchanged items #33", function(assert) {
+	canReflect.assignSymbols({},{
+		"can.getSchema": function() {
+			return {
+				type: "map",
+				identity: ["id"],
+				keys: {
+					id: Number,
+					name: String
+				}
+			};
+		}
+	});
+	
+	var items = [
+		{id: 1, name: "Item 0"},
+		{id: 2, name: "Item 1"},
+		{id: 3, name: "Item 1"},
+		{id: 4, name: "Item 1"},
+		{id: 5, name: "Item 2"}
+	];
+
+	canReflect.eachIndex(items, function(item, i) {
+		canReflect.assignSymbols(item, {
+			"can.getSchema": function() {
+				return {
+					type: "map",
+					identity: ["id"],
+					keys: {
+						id: Number,
+						name: String
+					}
+				};
+			}
+		});
+	});
+
+
+
+	var query = new BasicQuery({
+        sort: "name"
+	});
+	
+	var res = query.index({id:4, name: "Item 1"}, items);
+
+	QUnit.equal(res, 3);
+});