Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All marks should be classified in GDEF mark class #26

Open
glenda-tn opened this issue Jul 25, 2022 · 6 comments
Open

All marks should be classified in GDEF mark class #26

glenda-tn opened this issue Jul 25, 2022 · 6 comments
Assignees
Labels
Blocked enhancement New feature or request

Comments

@glenda-tn
Copy link
Collaborator

The following mark characters could be in the GDEF mark glyph class:

  • breve_inverted (U+0311)
@guidoferreyra
Copy link
Collaborator

All marks are now on GDEF mark class, except for uni0328 (ogonekcomb) because for creating GDEF data fontmake uses anchors in glyphs. ogonekcomb has _ogonek anchor which its seems is being ignored by fontmake. I will create an issue at their repo to get more info, but this is a minor issue.

@djrrb
Copy link
Collaborator

djrrb commented Dec 5, 2022

@guidoferreyra do you know the status on this, and if it’s worth keeping this issue open?

@guidoferreyra
Copy link
Collaborator

All glyphs except for /ogonekcomb are in the GDEF class.
I reported the issue googlefonts/fontmake#960
This is a minor thing, but can we keep it open for a few days more?

@djrrb
Copy link
Collaborator

djrrb commented Dec 5, 2022

that's fine...appreciate you linking to the issue so I didn’t have to go through all 222 open ones 😆

@djrrb djrrb added the enhancement New feature or request label Dec 6, 2022
@glenda-tn
Copy link
Collaborator Author

I just came here to report on the current results. I read the thread and understand about uni0328/ogonekcomb.

However, uni0323, the dotbelow, could/should be in the GDEF.

⚠️ WARN

UbuntuCondensed-Bold.ttf
UbuntuCondensed-Regular.ttf
UbuntuCondensed-Thin.ttf
UbuntuCondensed-ExtraBold.ttf
Ubuntu-Medium.ttf
Ubuntu-Thin.ttf
Ubuntu-LightItalic.ttf
Ubuntu-Regular.ttf
Ubuntu-Bold.ttf
Ubuntu-ExtraBold.ttf
Ubuntu-Light.ttf

The following mark characters could be in the GDEF mark glyph class: 
uni0323 (U+0323) [code: mark-chars]

@guidoferreyra
Copy link
Collaborator

This issue was addressed on the roman file. Italics still need to be "auto aligned" so better to wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants