Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neofetch ASCII logo looks stretched in Ubuntu Desktop #88

Open
elioqoshi opened this issue Apr 17, 2023 · 6 comments
Open

Neofetch ASCII logo looks stretched in Ubuntu Desktop #88

elioqoshi opened this issue Apr 17, 2023 · 6 comments

Comments

@elioqoshi
Copy link

Original comment: https://discourse.ubuntu.com/t/ubuntu-font-update-available-for-testing/34676/23

grafik

The ASCII logo in Neofetch looks distorted with the new font on Ubuntu Desktop.

I assume this is about the Monospaced font. Is there some variation in line height here?

@lyubomir-popov
Copy link
Collaborator

hi @djrrb, is this due to some metrics changes to comkply with Google Fonts?

@djrrb
Copy link
Collaborator

djrrb commented Apr 18, 2023

Yes I believe so. This follows their current standards but we can double check that this is the way they want it.

@lyubomir-popov
Copy link
Collaborator

@seb128 @local-optimum How is this ascii art logo created? If the change is due to a new google fonts standard that we need to adhere to, then maybe we need to regenerate that logo by updating settings in the software that generates it?

@elioqoshi
Copy link
Author

Not sure if I understand the right technical aspects, but I assume the required change would be to change the line height in the Ubuntu Terminal?

@lyubomir-popov
Copy link
Collaborator

lyubomir-popov commented Apr 18, 2023

I doubt we can touch that default. AFAIK ascii art samples an image and then choose the correct character and colour to render that original pixel as a character. What I'm proposing is re-running that generator to sample again, but feed it the updated version of the font, so that it takes the new metrics into account.

Here's an (oversimplified) example. On the left, low line-height text samples the colour underneath it, and changes colour to the respective colour in the image.

On the right, to simulate the new metrics, I have text with a higher line-height. If every colour samples from the correct (x,y) position from the logo underneath, no stretching would occur. Granted, the resolution of that ascii "rasterisation" might be lower, but that's a far lesser problem.

image

@joezhouchenye
Copy link

The cell width and height cannot be set to below 1.00 in gnome-terminal unfortunately. I can increase the width to make the shape correct but the text gap may be weird.

Change the Font to Monospace (Noto Mono and some other fonts work well too) and set the cell width to 1.10. The result is good.

The size is changed to 26 rows in my case to display all information without scrolling.

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants