Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin charmcraft channel to 3.x/stable #541

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Pin charmcraft channel to 3.x/stable #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16f27be
Pin charmcraft channel
mvlassis Sep 2, 2024
a836ce0
Add comment above the pinning to link to the proper issue
mvlassis Sep 2, 2024
bd1b909
Pin to 3.x instead of 3.1 which doesn't exist as a track
mvlassis Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/integrate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ jobs:
channel: ${{ matrix.microk8s-versions }}
microk8s-addons: "dns hostpath-storage rbac metallb:10.64.140.43-10.64.140.49"
juju-channel: 3.4/stable
charmcraft-channel: latest/candidate
# Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845
charmcraft-channel: 3.x/stable

- name: Run integration tests
run: |
Expand Down Expand Up @@ -139,7 +140,8 @@ jobs:
channel: ${{ matrix.microk8s-versions }}
microk8s-addons: "dns hostpath-storage rbac metallb:10.64.140.43-10.64.140.49"
juju-channel: 3.4/stable
charmcraft-channel: latest/candidate
# Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845
charmcraft-channel: 3.x/stable

- name: Run observability integration tests
run: |
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,5 @@ jobs:
charm-path: ${{ matrix.charm-path }}
channel: ${{ steps.parse-inputs.outputs.destination_channel }}
tag-prefix: ${{ steps.parse-inputs.outputs.tag_prefix }}
charmcraft-channel: latest/candidate
# Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845
charmcraft-channel: 3.x/stable
Loading