add more review requests

Author: rubinaga

src/features/local-repositories/api/useGetPageLocalRepository.ts

@@ -4,7 +4,7 @@ import type { Local } from "@canonical/landscape-openapi";
 
 type GetPageLocalRepositoryReturnType =
   | {
-      repository: Local | undefined;
+      repository: Local;
       isGettingRepository: false;
     }
   | {
@@ -29,6 +29,10 @@ export const useGetPageLocalRepository =
       };
     }
 
+    if (!repository) {
+      throw new Error("Local repository not found");
+    }
+
     return {
       repository: repository,
       isGettingRepository: false,

src/features/local-repositories/components/EditLocalRepositorySidePanel/EditLocalRepositorySidePanel.tsx

@@ -10,10 +10,6 @@ const EditLocalRepositorySidePanel: FC = () => {
     return <SidePanel.LoadingState />;
   }
 
-  if (!repository) {
-    throw new Error("Local repository not found");
-  }
-
   return (
     <>
       <SidePanel.Header>Edit {repository.displayName}</SidePanel.Header>

src/features/local-repositories/components/ImportRepositoryPackagesSidePanel/ImportRepositoryPackagesSidePanel.tsx

@@ -92,10 +92,6 @@ const ImportRepositoryPackagesSidePanel: FC = () => {
     return <SidePanel.LoadingState />;
   }
 
-  if (!repository) {
-    throw new Error("Local repository not found");
-  }
-
   const handleValidate = async () => {
     try {
       setOperationName("");

src/features/local-repositories/components/PublishLocalRepositorySidePanel/PublishLocalRepositorySidePanel.tsx

@@ -20,10 +20,6 @@ const PublishLocalRepositorySidePanel: FC = () => {
     return <SidePanel.LoadingState />;
   }
 
-  if (!repository) {
-    throw new Error("Local repository not found");
-  }
-
   return (
     <>
       <SidePanel.Header>Publish {repository.displayName}</SidePanel.Header>

src/features/local-repositories/components/ViewLocalRepositorySidePanel/ViewLocalRepositorySidePanel.tsx

@@ -16,10 +16,6 @@ const ViewLocalRepositorySidePanel: FC = () => {
     return <SidePanel.LoadingState />;
   }
 
-  if (!repository) {
-    throw new Error("Local repository not found");
-  }
-
   const tabs: { label: string; id: "details" | "packages" }[] = [
     {
       label: "General details",

src/features/profiles/components/AddProfileButton/AddProfileButton.test.tsx

@@ -3,7 +3,7 @@ import { withProfilesContext } from "@/tests/mocks/profilesContext";
 import { screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { useLocation } from "react-router";
-import { beforeEach, describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import AddProfileButton from "./AddProfileButton";
 
 const LocationDisplay = () => {
@@ -13,11 +13,6 @@ const LocationDisplay = () => {
 };
 
 describe("AddProfileButton", () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    localStorage.clear();
-  });
-
   it("displays specific appearance for scripts header", () => {
     renderWithProviders(
       <AddProfileButton isInsideScriptHeader />,

src/features/repository-profiles/components/RepositoryProfileList/RepositoryProfileList.test.tsx

@@ -34,11 +34,9 @@ describe("RepositoryProfileList", () => {
       const accessGroup = accessGroups.find(
         (group) => group.name === profile.access_group,
       )?.title;
+      assert(accessGroup);
 
-      expect(accessGroup).toBeDefined();
-      expect(
-        await within(row).findByText(accessGroup ?? ""),
-      ).toBeInTheDocument();
+      expect(await within(row).findByText(accessGroup)).toBeInTheDocument();
     }
   });
 
@@ -80,19 +78,15 @@ describe("RepositoryProfileList", () => {
       name: (name) =>
         name.toLowerCase().includes(firstProfile.title.toLowerCase()),
     });
+    assert(accessGroup);
 
-    expect(accessGroup).toBeDefined();
-    expect(await within(row).findByText(accessGroup ?? "")).toBeInTheDocument();
+    expect(await within(row).findByText(accessGroup)).toBeInTheDocument();
 
     const profileButton = within(row).getByRole("button", {
       name: firstProfile.title,
     });
     await user.click(profileButton);
 
-    expect(
-      within(row).getByRole("button", { name: firstProfile.title }),
-    ).toBeInTheDocument();
-
     expect(await screen.findByTestId("location")).toHaveTextContent(
       "sidePath=view",
     );

src/tests/controllers/controller.ts

@@ -41,16 +41,6 @@ export const getEndpointStatus = (path?: string): EndpointStatus => {
     if (targetedStatus) {
       return targetedStatus;
     }
-
-    const globalStatus = endpointStatuses.find(
-      (status) => !normalizeEndpointPath(status.path),
-    );
-
-    if (globalStatus) {
-      return globalStatus;
-    }
-
-    return DEFAULT_ENDPOINT_STATUS;
   }
 
   const globalStatus = endpointStatuses.find(
@@ -61,7 +51,7 @@ export const getEndpointStatus = (path?: string): EndpointStatus => {
     return globalStatus;
   }
 
-  if (hasOneItem(endpointStatuses)) {
+  if (!path && hasOneItem(endpointStatuses)) {
     return endpointStatuses[0];
   }