From 95914a7a4ae76105cd67ae2530a2879918d6f615 Mon Sep 17 00:00:00 2001 From: David Edler Date: Thu, 29 Feb 2024 20:42:35 +0100 Subject: [PATCH] chore(urls) use shorter urls, without /detail/ in path WD-9320 Signed-off-by: David Edler --- src/App.tsx | 38 +++++++++---------- src/components/NavLink.tsx | 29 ++++++++++++++ src/components/Navigation.tsx | 33 +++------------- src/pages/cluster/ClusterGroupForm.tsx | 2 +- .../cluster/ClusterGroupSelectorList.tsx | 2 +- .../cluster/actions/EditClusterGroupBtn.tsx | 2 +- src/pages/instances/CreateInstance.tsx | 4 +- src/pages/instances/EditInstance.tsx | 2 +- src/pages/instances/FileRow.tsx | 2 +- src/pages/instances/InstanceDetail.tsx | 2 +- src/pages/instances/InstanceDetailHeader.tsx | 2 +- src/pages/instances/InstanceDetailPanel.tsx | 14 +++---- src/pages/instances/InstanceLink.tsx | 2 +- .../instances/InstanceOverviewNetworks.tsx | 2 +- .../instances/InstanceOverviewProfiles.tsx | 2 +- .../instances/actions/OpenConsoleBtn.tsx | 2 +- .../instances/actions/OpenTerminalBtn.tsx | 2 +- src/pages/networks/CreateNetworkForward.tsx | 6 +-- src/pages/networks/EditNetwork.tsx | 2 +- src/pages/networks/EditNetworkForward.tsx | 6 +-- src/pages/networks/MapTooltip.tsx | 4 +- src/pages/networks/NetworkDetail.tsx | 2 +- src/pages/networks/NetworkDetailHeader.tsx | 2 +- src/pages/networks/NetworkDetailOverview.tsx | 2 +- src/pages/networks/NetworkForwards.tsx | 4 +- src/pages/networks/NetworkList.tsx | 2 +- src/pages/profiles/EditProfile.tsx | 4 +- src/pages/profiles/ProfileDetail.tsx | 2 +- src/pages/profiles/ProfileDetailHeader.tsx | 2 +- src/pages/profiles/ProfileDetailOverview.tsx | 4 +- src/pages/profiles/ProfileLink.tsx | 2 +- src/pages/storage/CustomIsoList.tsx | 2 +- src/pages/storage/EditStoragePool.tsx | 2 +- src/pages/storage/StoragePoolDetail.tsx | 2 +- src/pages/storage/StoragePoolHeader.tsx | 2 +- src/pages/storage/StoragePools.tsx | 2 +- src/pages/storage/StorageUsedBy.tsx | 10 ++--- src/pages/storage/StorageVolumeDetail.tsx | 2 +- src/pages/storage/StorageVolumeHeader.tsx | 2 +- src/pages/storage/StorageVolumeNameLink.tsx | 4 +- src/pages/storage/StorageVolumeOverview.tsx | 2 +- src/pages/storage/StorageVolumes.tsx | 2 +- src/pages/storage/forms/StorageVolumeEdit.tsx | 2 +- 43 files changed, 109 insertions(+), 111 deletions(-) create mode 100644 src/components/NavLink.tsx diff --git a/src/App.tsx b/src/App.tsx index d04f318f56..99873c2f9f 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -113,7 +113,7 @@ const App: FC = () => { } /> } />} @@ -121,7 +121,7 @@ const App: FC = () => { } /> } />} @@ -129,7 +129,7 @@ const App: FC = () => { } /> } />} @@ -153,7 +153,7 @@ const App: FC = () => { } /> } />} @@ -161,7 +161,7 @@ const App: FC = () => { } /> } />} @@ -169,7 +169,7 @@ const App: FC = () => { } /> } />} @@ -193,7 +193,7 @@ const App: FC = () => { } /> } />} @@ -201,7 +201,7 @@ const App: FC = () => { } /> } />} @@ -209,7 +209,7 @@ const App: FC = () => { } /> } />} @@ -217,7 +217,7 @@ const App: FC = () => { } /> } />} @@ -225,7 +225,7 @@ const App: FC = () => { } /> } />} @@ -289,7 +289,7 @@ const App: FC = () => { } /> } />} @@ -297,23 +297,23 @@ const App: FC = () => { } /> } />} /> } />} /> } />} /> } />} /> } />} /> { element={} />} /> } />} @@ -337,7 +337,7 @@ const App: FC = () => { } /> } />} diff --git a/src/components/NavLink.tsx b/src/components/NavLink.tsx new file mode 100644 index 0000000000..121d5d7b69 --- /dev/null +++ b/src/components/NavLink.tsx @@ -0,0 +1,29 @@ +import { FC, ReactNode } from "react"; +import { Link, useLocation } from "react-router-dom"; + +interface Props { + to: string; + title: string; + children: ReactNode; +} + +const NavLink: FC = ({ to, title, children }) => { + const location = useLocation(); + + // ignore last char to consider /instances and /instance as active + const matchPart = to.substring(0, to.length - 1); + const isActive = location.pathname.startsWith(matchPart); + + return ( + + {children} + + ); +}; + +export default NavLink; diff --git a/src/components/Navigation.tsx b/src/components/Navigation.tsx index bda895ab0c..de10688dcd 100644 --- a/src/components/Navigation.tsx +++ b/src/components/Navigation.tsx @@ -1,5 +1,4 @@ import { FC, MouseEvent, useEffect, useState } from "react"; -import { NavLink } from "react-router-dom"; import { Button, Icon } from "@canonical/react-components"; import { useAuth } from "context/auth"; import classnames from "classnames"; @@ -9,6 +8,7 @@ import { isWidthBelow, logout } from "util/helpers"; import { useProject } from "context/project"; import { useMenuCollapsed } from "context/menuCollapsed"; import { useDocs } from "context/useDocs"; +import NavLink from "components/NavLink"; const isSmallScreen = () => isWidthBelow(620); @@ -92,7 +92,6 @@ const Navigation: FC = () => {
  • @@ -105,7 +104,6 @@ const Navigation: FC = () => {
  • @@ -118,7 +116,6 @@ const Navigation: FC = () => {
  • @@ -131,7 +128,6 @@ const Navigation: FC = () => {
  • @@ -144,7 +140,6 @@ const Navigation: FC = () => {
  • @@ -157,7 +152,6 @@ const Navigation: FC = () => {
  • @@ -170,11 +164,7 @@ const Navigation: FC = () => {

  • - + {
  • @@ -197,11 +186,7 @@ const Navigation: FC = () => {
  • {!isRestricted && (
  • - + {
  • )}
  • - + { {!isAuthenticated && ( <>
  • - + = ({ group }) => { }) .then(() => { const verb = group ? "saved" : "created"; - navigate(`/ui/cluster/groups/detail/${values.name}`); + navigate(`/ui/cluster/group/${values.name}`); toastNotify.success(`Cluster group ${values.name} ${verb}.`); }) .catch((e: Error) => { diff --git a/src/pages/cluster/ClusterGroupSelectorList.tsx b/src/pages/cluster/ClusterGroupSelectorList.tsx index f91b689612..9017a99bc5 100644 --- a/src/pages/cluster/ClusterGroupSelectorList.tsx +++ b/src/pages/cluster/ClusterGroupSelectorList.tsx @@ -28,7 +28,7 @@ const ClusterGroupSelectorList: FC = ({ clusterGroups }) => { to={ group.name === allClusterGroups ? "/ui/cluster" - : `/ui/cluster/groups/detail/${group.name}` + : `/ui/cluster/group/${group.name}` } className="p-contextual-menu__link link" > diff --git a/src/pages/cluster/actions/EditClusterGroupBtn.tsx b/src/pages/cluster/actions/EditClusterGroupBtn.tsx index 9ba8169593..a749ec546f 100644 --- a/src/pages/cluster/actions/EditClusterGroupBtn.tsx +++ b/src/pages/cluster/actions/EditClusterGroupBtn.tsx @@ -12,7 +12,7 @@ const EditClusterGroupBtn: FC = ({ group }) => { return ( diff --git a/src/pages/instances/CreateInstance.tsx b/src/pages/instances/CreateInstance.tsx index 98535a71db..9743ec1ded 100644 --- a/src/pages/instances/CreateInstance.tsx +++ b/src/pages/instances/CreateInstance.tsx @@ -200,7 +200,7 @@ const CreateInstance: FC = () => { isIsoImage: boolean, ) => { const instanceLink = ( - + {instanceName} ); @@ -218,7 +218,7 @@ const CreateInstance: FC = () => { ); }); } else { - const consoleUrl = `/ui/project/${project}/instances/detail/${instanceName}/console`; + const consoleUrl = `/ui/project/${project}/instance/${instanceName}/console`; const message = isIsoImage && ( <>

    Continue the installation process from its console.

    diff --git a/src/pages/instances/EditInstance.tsx b/src/pages/instances/EditInstance.tsx index 9433fb4161..2d78f85eb5 100644 --- a/src/pages/instances/EditInstance.tsx +++ b/src/pages/instances/EditInstance.tsx @@ -146,7 +146,7 @@ const EditInstance: FC = ({ instance }) => { void formik.setFieldValue("yaml", undefined); } - const baseUrl = `/ui/project/${project}/instances/detail/${instance.name}/configuration`; + const baseUrl = `/ui/project/${project}/instance/${instance.name}/configuration`; newSection === MAIN_CONFIGURATION ? navigate(baseUrl) : navigate(`${baseUrl}/${slugify(newSection)}`); diff --git a/src/pages/instances/FileRow.tsx b/src/pages/instances/FileRow.tsx index 9dfbb2c98f..57a0c1206b 100644 --- a/src/pages/instances/FileRow.tsx +++ b/src/pages/instances/FileRow.tsx @@ -14,7 +14,7 @@ interface FileRowProps { const FileRow: FC = ({ instance, path }) => { const fileName = path.split("/").at(-1) ?? ""; - const fileUrl = `/ui/project/${instance.project}/instances/detail/${instance.name}/logs/?file=${fileName}`; + const fileUrl = `/ui/project/${instance.project}/instance/${instance.name}/logs/?file=${fileName}`; const [isOpen, setOpen] = useState(getUrlParam("file") === fileName); const { diff --git a/src/pages/instances/InstanceDetail.tsx b/src/pages/instances/InstanceDetail.tsx index aee397776d..154e79fe7f 100644 --- a/src/pages/instances/InstanceDetail.tsx +++ b/src/pages/instances/InstanceDetail.tsx @@ -72,7 +72,7 @@ const InstanceDetail: FC = () => { {!activeTab && ( diff --git a/src/pages/instances/InstanceDetailHeader.tsx b/src/pages/instances/InstanceDetailHeader.tsx index 813067439d..10a0f9faa3 100644 --- a/src/pages/instances/InstanceDetailHeader.tsx +++ b/src/pages/instances/InstanceDetailHeader.tsx @@ -66,7 +66,7 @@ const InstanceDetailHeader: FC = ({ name, instance, project }) => { eventQueue.set( operation.metadata.id, () => { - navigate(`/ui/project/${project}/instances/detail/${values.name}`); + navigate(`/ui/project/${project}/instance/${values.name}`); toastNotify.success( <> Instance {getInstanceName(operation.metadata)}{" "} diff --git a/src/pages/instances/InstanceDetailPanel.tsx b/src/pages/instances/InstanceDetailPanel.tsx index 7839bb0353..02f029354b 100644 --- a/src/pages/instances/InstanceDetailPanel.tsx +++ b/src/pages/instances/InstanceDetailPanel.tsx @@ -144,7 +144,7 @@ const InstanceDetailPanel: FC = () => {

    Profiles @@ -156,7 +156,7 @@ const InstanceDetailPanel: FC = () => { items={instance.profiles.map((name) => ( {name} @@ -175,7 +175,7 @@ const InstanceDetailPanel: FC = () => { items={networkDevices.map((item) => ( {item.network} @@ -191,7 +191,7 @@ const InstanceDetailPanel: FC = () => { No networks found.
    Configure instance networks @@ -203,7 +203,7 @@ const InstanceDetailPanel: FC = () => {

    Snapshots @@ -237,7 +237,7 @@ const InstanceDetailPanel: FC = () => { {`View all (${instance.snapshots.length})`} @@ -252,7 +252,7 @@ const InstanceDetailPanel: FC = () => { No snapshots found.
    Manage instance snapshots diff --git a/src/pages/instances/InstanceLink.tsx b/src/pages/instances/InstanceLink.tsx index a333532468..1e1f806d38 100644 --- a/src/pages/instances/InstanceLink.tsx +++ b/src/pages/instances/InstanceLink.tsx @@ -12,7 +12,7 @@ interface Props { const InstanceLink: FC = ({ instance }) => { return ( e.stopPropagation()} > diff --git a/src/pages/instances/InstanceOverviewNetworks.tsx b/src/pages/instances/InstanceOverviewNetworks.tsx index f1226d16e9..36aa750eb4 100644 --- a/src/pages/instances/InstanceOverviewNetworks.tsx +++ b/src/pages/instances/InstanceOverviewNetworks.tsx @@ -63,7 +63,7 @@ const InstanceOverviewNetworks: FC = ({ instance, onFailure }) => { { content: ( {network.name} diff --git a/src/pages/instances/InstanceOverviewProfiles.tsx b/src/pages/instances/InstanceOverviewProfiles.tsx index 1b32801016..d994cc57ba 100644 --- a/src/pages/instances/InstanceOverviewProfiles.tsx +++ b/src/pages/instances/InstanceOverviewProfiles.tsx @@ -48,7 +48,7 @@ const InstanceOverviewProfiles: FC = ({ instance, onFailure }) => { { content: ( {profile} diff --git a/src/pages/instances/actions/OpenConsoleBtn.tsx b/src/pages/instances/actions/OpenConsoleBtn.tsx index 7c214dd90c..10ccad5630 100644 --- a/src/pages/instances/actions/OpenConsoleBtn.tsx +++ b/src/pages/instances/actions/OpenConsoleBtn.tsx @@ -12,7 +12,7 @@ const OpenConsoleBtn: FC = ({ instance }) => { const handleOpen = () => { navigate( - `/ui/project/${instance.project}/instances/detail/${instance.name}/console`, + `/ui/project/${instance.project}/instance/${instance.name}/console`, ); }; diff --git a/src/pages/instances/actions/OpenTerminalBtn.tsx b/src/pages/instances/actions/OpenTerminalBtn.tsx index aa875a167a..247806960f 100644 --- a/src/pages/instances/actions/OpenTerminalBtn.tsx +++ b/src/pages/instances/actions/OpenTerminalBtn.tsx @@ -12,7 +12,7 @@ const OpenTerminalBtn: FC = ({ instance }) => { const handleOpen = () => { navigate( - `/ui/project/${instance.project}/instances/detail/${instance.name}/terminal`, + `/ui/project/${instance.project}/instance/${instance.name}/terminal`, ); }; diff --git a/src/pages/networks/CreateNetworkForward.tsx b/src/pages/networks/CreateNetworkForward.tsx index cdbdba5efb..403987b2e6 100644 --- a/src/pages/networks/CreateNetworkForward.tsx +++ b/src/pages/networks/CreateNetworkForward.tsx @@ -46,9 +46,7 @@ const CreateNetworkForward: FC = () => { queryKeys.forwards, ], }); - navigate( - `/ui/project/${project}/networks/detail/${network}/forwards`, - ); + navigate(`/ui/project/${project}/network/${network}/forwards`); toastNotify.success( `Network forward ${forward.listen_address} created.`, ); @@ -80,7 +78,7 @@ const CreateNetworkForward: FC = () => { Cancel diff --git a/src/pages/networks/EditNetwork.tsx b/src/pages/networks/EditNetwork.tsx index d2ef4447a5..7669a129c1 100644 --- a/src/pages/networks/EditNetwork.tsx +++ b/src/pages/networks/EditNetwork.tsx @@ -124,7 +124,7 @@ const EditNetwork: FC = ({ network, project }) => { void formik.setFieldValue("yaml", undefined); } - const baseUrl = `/ui/project/${project}/networks/detail/${network.name}/configuration`; + const baseUrl = `/ui/project/${project}/network/${network.name}/configuration`; newSection === MAIN_CONFIGURATION ? navigate(baseUrl) : navigate(`${baseUrl}/${slugify(newSection)}`); diff --git a/src/pages/networks/EditNetworkForward.tsx b/src/pages/networks/EditNetworkForward.tsx index 946df48cda..3783e34c6b 100644 --- a/src/pages/networks/EditNetworkForward.tsx +++ b/src/pages/networks/EditNetworkForward.tsx @@ -73,9 +73,7 @@ const EditNetworkForward: FC = () => { queryKeys.forwards, ], }); - navigate( - `/ui/project/${project}/networks/detail/${network}/forwards`, - ); + navigate(`/ui/project/${project}/network/${network}/forwards`); toastNotify.success( `Network forward ${forward.listen_address} updated.`, ); @@ -108,7 +106,7 @@ const EditNetworkForward: FC = () => { Cancel diff --git a/src/pages/networks/MapTooltip.tsx b/src/pages/networks/MapTooltip.tsx index e59d41f400..53bc896a76 100644 --- a/src/pages/networks/MapTooltip.tsx +++ b/src/pages/networks/MapTooltip.tsx @@ -33,9 +33,7 @@ const MapTooltip: FC = ({ item, type }) => { return (
    - +
    diff --git a/src/pages/networks/NetworkDetail.tsx b/src/pages/networks/NetworkDetail.tsx index d5e8d6a09c..2f86033a1d 100644 --- a/src/pages/networks/NetworkDetail.tsx +++ b/src/pages/networks/NetworkDetail.tsx @@ -50,7 +50,7 @@ const NetworkDetail: FC = () => { {!activeTab && ( diff --git a/src/pages/networks/NetworkDetailHeader.tsx b/src/pages/networks/NetworkDetailHeader.tsx index f2fb1a3abf..28e8cbbbff 100644 --- a/src/pages/networks/NetworkDetailHeader.tsx +++ b/src/pages/networks/NetworkDetailHeader.tsx @@ -48,7 +48,7 @@ const NetworkDetailHeader: FC = ({ name, network, project }) => { } renameNetwork(name, values.name, project) .then(() => { - navigate(`/ui/project/${project}/networks/detail/${values.name}`); + navigate(`/ui/project/${project}/network/${values.name}`); toastNotify.success(`Network ${name} renamed to ${values.name}.`); void formik.setFieldValue("isRenaming", false); }) diff --git a/src/pages/networks/NetworkDetailOverview.tsx b/src/pages/networks/NetworkDetailOverview.tsx index 1b7fcc41bb..48dafa5880 100644 --- a/src/pages/networks/NetworkDetailOverview.tsx +++ b/src/pages/networks/NetworkDetailOverview.tsx @@ -162,7 +162,7 @@ const NetworkDetailOverview: FC = ({ network }) => { items={data.profiles.map((item) => (
    {item.name} diff --git a/src/pages/networks/NetworkForwards.tsx b/src/pages/networks/NetworkForwards.tsx index 5be232ec0b..2e92b8e69f 100644 --- a/src/pages/networks/NetworkForwards.tsx +++ b/src/pages/networks/NetworkForwards.tsx @@ -90,7 +90,7 @@ const NetworkForwards: FC = ({ network, project }) => { <> @@ -124,7 +124,7 @@ const NetworkForwards: FC = ({ network, project }) => { <> Create forward diff --git a/src/pages/networks/NetworkList.tsx b/src/pages/networks/NetworkList.tsx index 890432bd27..a813408b28 100644 --- a/src/pages/networks/NetworkList.tsx +++ b/src/pages/networks/NetworkList.tsx @@ -60,7 +60,7 @@ const NetworkList: FC = () => { columns: [ { content: ( - + {network.name} ), diff --git a/src/pages/profiles/EditProfile.tsx b/src/pages/profiles/EditProfile.tsx index 7f4df3a40c..a41c574c2d 100644 --- a/src/pages/profiles/EditProfile.tsx +++ b/src/pages/profiles/EditProfile.tsx @@ -150,7 +150,7 @@ const EditProfile: FC = ({ profile, featuresProfiles }) => { void formik.setFieldValue("yaml", undefined); } - const baseUrl = `/ui/project/${project}/profiles/detail/${profile.name}/configuration`; + const baseUrl = `/ui/project/${project}/profile/${profile.name}/configuration`; newSection === MAIN_CONFIGURATION ? navigate(baseUrl) : navigate(`${baseUrl}/${slugify(newSection)}`); @@ -176,7 +176,7 @@ const EditProfile: FC = ({ profile, featuresProfiles }) => { Modifications are only available in the{" "} default project diff --git a/src/pages/profiles/ProfileDetail.tsx b/src/pages/profiles/ProfileDetail.tsx index b8f7f36676..55363ffa36 100644 --- a/src/pages/profiles/ProfileDetail.tsx +++ b/src/pages/profiles/ProfileDetail.tsx @@ -74,7 +74,7 @@ const ProfileDetail: FC = () => { {!activeTab && ( diff --git a/src/pages/profiles/ProfileDetailHeader.tsx b/src/pages/profiles/ProfileDetailHeader.tsx index 5fa9d7a88f..b64d72620d 100644 --- a/src/pages/profiles/ProfileDetailHeader.tsx +++ b/src/pages/profiles/ProfileDetailHeader.tsx @@ -54,7 +54,7 @@ const ProfileDetailHeader: FC = ({ } renameProfile(name, values.name, project) .then(() => { - navigate(`/ui/project/${project}/profiles/detail/${values.name}`); + navigate(`/ui/project/${project}/profile/${values.name}`); toastNotify.success(`Profile ${name} renamed to ${values.name}.`); void formik.setFieldValue("isRenaming", false); }) diff --git a/src/pages/profiles/ProfileDetailOverview.tsx b/src/pages/profiles/ProfileDetailOverview.tsx index 8e83cde175..ec10d1b273 100644 --- a/src/pages/profiles/ProfileDetailOverview.tsx +++ b/src/pages/profiles/ProfileDetailOverview.tsx @@ -48,7 +48,7 @@ const ProfileDetailOverview: FC = ({ profile, featuresProfiles }) => { {!featuresProfiles && ( Modifications are only available in the{" "} - + default project . @@ -127,7 +127,7 @@ const ProfileDetailOverview: FC = ({ profile, featuresProfiles }) => { diff --git a/src/pages/profiles/ProfileLink.tsx b/src/pages/profiles/ProfileLink.tsx index bbf8c67379..de8fadbd80 100644 --- a/src/pages/profiles/ProfileLink.tsx +++ b/src/pages/profiles/ProfileLink.tsx @@ -12,7 +12,7 @@ interface Props { const ProfileLink: FC = ({ profile }) => { return ( e.stopPropagation()} > diff --git a/src/pages/storage/CustomIsoList.tsx b/src/pages/storage/CustomIsoList.tsx index 9db3e151da..8772aa6f17 100644 --- a/src/pages/storage/CustomIsoList.tsx +++ b/src/pages/storage/CustomIsoList.tsx @@ -86,7 +86,7 @@ const CustomIsoList: FC = ({ project }) => { { content: (
    - + {image.pool}
    diff --git a/src/pages/storage/EditStoragePool.tsx b/src/pages/storage/EditStoragePool.tsx index 42d6df1264..0f399c0080 100644 --- a/src/pages/storage/EditStoragePool.tsx +++ b/src/pages/storage/EditStoragePool.tsx @@ -90,7 +90,7 @@ const EditStoragePool: FC = ({ pool }) => { }); const setSection = (newSection: string) => { - const baseUrl = `/ui/project/${project}/storage/detail/${pool.name}/configuration`; + const baseUrl = `/ui/project/${project}/storage/pool/${pool.name}/configuration`; newSection === MAIN_CONFIGURATION ? navigate(baseUrl) : navigate(`${baseUrl}/${slugify(newSection)}`); diff --git a/src/pages/storage/StoragePoolDetail.tsx b/src/pages/storage/StoragePoolDetail.tsx index b103f9b2a5..2bb8b767d7 100644 --- a/src/pages/storage/StoragePoolDetail.tsx +++ b/src/pages/storage/StoragePoolDetail.tsx @@ -77,7 +77,7 @@ const StoragePoolDetail: FC = () => { {!activeTab && ( diff --git a/src/pages/storage/StoragePoolHeader.tsx b/src/pages/storage/StoragePoolHeader.tsx index 4714e183e7..b46790294b 100644 --- a/src/pages/storage/StoragePoolHeader.tsx +++ b/src/pages/storage/StoragePoolHeader.tsx @@ -42,7 +42,7 @@ const StoragePoolHeader: FC = ({ name, pool, project }) => { } renameStoragePool(name, values.name, project) .then(() => { - navigate(`/ui/project/${project}/storage/detail/${values.name}`); + navigate(`/ui/project/${project}/storage/pool/${values.name}`); toastNotify.success( `Storage pool ${name} renamed to ${values.name}.`, ); diff --git a/src/pages/storage/StoragePools.tsx b/src/pages/storage/StoragePools.tsx index 3fc4950fba..bb94853470 100644 --- a/src/pages/storage/StoragePools.tsx +++ b/src/pages/storage/StoragePools.tsx @@ -86,7 +86,7 @@ const StoragePools: FC = () => { columns: [ { content: ( - + {pool.name} ), diff --git a/src/pages/storage/StorageUsedBy.tsx b/src/pages/storage/StorageUsedBy.tsx index 43a10adc5b..f1ead00096 100644 --- a/src/pages/storage/StorageUsedBy.tsx +++ b/src/pages/storage/StorageUsedBy.tsx @@ -52,9 +52,7 @@ const StorageUsedBy: FC = ({ storage, project }) => { (
    - + {item.name} {item.project !== project && ` (project ${item.project})`} @@ -89,7 +87,7 @@ const StorageUsedBy: FC = ({ storage, project }) => { {item.instance && (
    {`${item.instance} ${item.name}`} @@ -101,7 +99,7 @@ const StorageUsedBy: FC = ({ storage, project }) => { key={`${item.volume}-${item.name}-${item.project}-${item.pool}`} > {`${item.volume} ${item.name}`} @@ -122,7 +120,7 @@ const StorageUsedBy: FC = ({ storage, project }) => { items={data[CUSTOM_VOLUMES].map((item) => (
    {item.name} diff --git a/src/pages/storage/StorageVolumeDetail.tsx b/src/pages/storage/StorageVolumeDetail.tsx index 740503f5db..2d16afc523 100644 --- a/src/pages/storage/StorageVolumeDetail.tsx +++ b/src/pages/storage/StorageVolumeDetail.tsx @@ -72,7 +72,7 @@ const StorageVolumeDetail: FC = () => { {!activeTab && ( diff --git a/src/pages/storage/StorageVolumeHeader.tsx b/src/pages/storage/StorageVolumeHeader.tsx index b0b4311733..7de87beaf3 100644 --- a/src/pages/storage/StorageVolumeHeader.tsx +++ b/src/pages/storage/StorageVolumeHeader.tsx @@ -50,7 +50,7 @@ const StorageVolumeHeader: FC = ({ volume, project }) => { renameStorageVolume(project, volume, values.name) .then(() => { navigate( - `/ui/project/${project}/storage/detail/${volume.pool}/volumes/${volume.type}/${values.name}`, + `/ui/project/${project}/storage/pool/${volume.pool}/volumes/${volume.type}/${values.name}`, ); toastNotify.success( `Storage volume ${volume.name} renamed to ${values.name}.`, diff --git a/src/pages/storage/StorageVolumeNameLink.tsx b/src/pages/storage/StorageVolumeNameLink.tsx index 954e9eb6aa..b976bdd637 100644 --- a/src/pages/storage/StorageVolumeNameLink.tsx +++ b/src/pages/storage/StorageVolumeNameLink.tsx @@ -17,11 +17,11 @@ export const generateLinkForVolumeDetail = (args: { project: string; }) => { const { volume, project } = args; - let path = `storage/detail/${volume.pool}/volumes/${volume.type}/${volume.name}`; + let path = `storage/pool/${volume.pool}/volumes/${volume.type}/${volume.name}`; // NOTE: name of a volume created from an instance is exactly the same as the instance name if (volume.type === "container" || volume.type === "virtual-machine") { - path = `instances/detail/${volume.name}`; + path = `instance/${volume.name}`; } if (volume.type === "image") { diff --git a/src/pages/storage/StorageVolumeOverview.tsx b/src/pages/storage/StorageVolumeOverview.tsx index 63ae96c65d..2b34fbee89 100644 --- a/src/pages/storage/StorageVolumeOverview.tsx +++ b/src/pages/storage/StorageVolumeOverview.tsx @@ -54,7 +54,7 @@ const StorageVolumeOverview: FC = ({ project, volume }) => { Pool {volume.pool} diff --git a/src/pages/storage/StorageVolumes.tsx b/src/pages/storage/StorageVolumes.tsx index 918e66e9a4..2f40f20215 100644 --- a/src/pages/storage/StorageVolumes.tsx +++ b/src/pages/storage/StorageVolumes.tsx @@ -237,7 +237,7 @@ const StorageVolumes: FC = () => { }, { content: ( - + {volume.pool} ), diff --git a/src/pages/storage/forms/StorageVolumeEdit.tsx b/src/pages/storage/forms/StorageVolumeEdit.tsx index f6e8b3890d..9309e2089a 100644 --- a/src/pages/storage/forms/StorageVolumeEdit.tsx +++ b/src/pages/storage/forms/StorageVolumeEdit.tsx @@ -70,7 +70,7 @@ const StorageVolumeEdit: FC = ({ volume }) => { }); const setSection = (newSection: string) => { - const baseUrl = `/ui/project/${project}/storage/detail/${volume.pool}/volumes/${volume.type}/${volume.name}/configuration`; + const baseUrl = `/ui/project/${project}/storage/pool/${volume.pool}/volumes/${volume.type}/${volume.name}/configuration`; newSection === MAIN_CONFIGURATION ? navigate(baseUrl) : navigate(`${baseUrl}/${slugify(newSection)}`);