From a400ff703b68dc2e3e43245b7d2fae0a6e2de7b2 Mon Sep 17 00:00:00 2001
From: David Edler <david.edler@canonical.com>
Date: Wed, 10 May 2023 11:47:48 +0200
Subject: [PATCH] feat(cert) ask for certificate password on creation #331

---
 .../certificates/CertificateGenerate.tsx      | 23 ++++-
 src/pages/certificates/PasswordModal.tsx      | 83 +++++++++++++++++++
 src/util/certificate.tsx                      |  4 +-
 3 files changed, 105 insertions(+), 5 deletions(-)
 create mode 100644 src/pages/certificates/PasswordModal.tsx

diff --git a/src/pages/certificates/CertificateGenerate.tsx b/src/pages/certificates/CertificateGenerate.tsx
index 1120e9a5a1..cf4bb9712b 100644
--- a/src/pages/certificates/CertificateGenerate.tsx
+++ b/src/pages/certificates/CertificateGenerate.tsx
@@ -5,6 +5,7 @@ import BrowserImport from "pages/certificates/BrowserImport";
 import { Navigate } from "react-router-dom";
 import { useAuth } from "context/auth";
 import Loader from "components/Loader";
+import PasswordModal from "pages/certificates/PasswordModal";
 
 interface Certs {
   crt: string;
@@ -13,6 +14,7 @@ interface Certs {
 
 const CertificateGenerate: FC = () => {
   const [isGenerating, setGenerating] = useState(false);
+  const [isModalOpen, setModalOpen] = useState(false);
   const [certs, setCerts] = useState<Certs | null>(null);
   const { isAuthenticated, isAuthLoading } = useAuth();
 
@@ -24,11 +26,20 @@ const CertificateGenerate: FC = () => {
     return <Navigate to="/ui" replace={true} />;
   }
 
-  const createCert = () => {
+  const closeModal = () => {
+    setModalOpen(false);
+  };
+
+  const openModal = () => {
+    setModalOpen(true);
+  };
+
+  const createCert = (password: string) => {
+    closeModal();
     setGenerating(true);
     // using timeout to avoid compute heavy generation in the main ui thread
     setTimeout(() => {
-      const certs = generateCert();
+      const certs = generateCert(password);
       setCerts(certs);
       setGenerating(false);
     }, 10);
@@ -76,8 +87,14 @@ const CertificateGenerate: FC = () => {
                       </div>
                     </Col>
                     <Col size={3}>
+                      {isModalOpen && (
+                        <PasswordModal
+                          onClose={closeModal}
+                          onConfirm={createCert}
+                        />
+                      )}
                       <Button
-                        onClick={createCert}
+                        onClick={openModal}
                         appearance="positive"
                         disabled={isGenerating || certs !== null}
                         hasIcon={isGenerating}
diff --git a/src/pages/certificates/PasswordModal.tsx b/src/pages/certificates/PasswordModal.tsx
new file mode 100644
index 0000000000..f274290c1c
--- /dev/null
+++ b/src/pages/certificates/PasswordModal.tsx
@@ -0,0 +1,83 @@
+import React, { FC } from "react";
+import { Button, Input, Modal } from "@canonical/react-components";
+import { useFormik } from "formik";
+import * as Yup from "yup";
+
+interface Props {
+  onConfirm: (password: string) => void;
+  onClose: () => void;
+}
+
+const PasswordModal: FC<Props> = ({ onConfirm, onClose }) => {
+  const PasswordSchema = Yup.object().shape({
+    password: Yup.string(),
+    passwordConfirm: Yup.string().oneOf(
+      [Yup.ref("password"), null],
+      "Passwords must match"
+    ),
+  });
+
+  const formik = useFormik({
+    initialValues: {
+      password: "",
+      passwordConfirm: "",
+    },
+    validationSchema: PasswordSchema,
+    onSubmit: (values) => {
+      onConfirm(values.password);
+    },
+  });
+
+  const handleSkip = () => {
+    onConfirm("");
+  };
+
+  return (
+    <Modal
+      close={onClose}
+      title="Add a password"
+      buttonRow={
+        <>
+          <Button className="u-no-margin--bottom" onClick={handleSkip}>
+            Skip
+          </Button>
+          <Button
+            appearance="positive"
+            className="u-no-margin--bottom"
+            onClick={() => formik.submitForm()}
+            disabled={
+              formik.values.password !== formik.values.passwordConfirm ||
+              formik.values.password.length === 0
+            }
+          >
+            Generate certificate
+          </Button>
+        </>
+      }
+    >
+      <p>Protect your certificate by adding a password.</p>
+      <Input
+        id="password"
+        type="password"
+        label="Password"
+        onBlur={formik.handleBlur}
+        onChange={formik.handleChange}
+        value={formik.values.password}
+        error={formik.touched.password ? formik.errors.password : null}
+      />
+      <Input
+        id="passwordConfirm"
+        type="password"
+        label="Password confirmation"
+        onBlur={formik.handleBlur}
+        onChange={formik.handleChange}
+        value={formik.values.passwordConfirm}
+        error={
+          formik.touched.passwordConfirm ? formik.errors.passwordConfirm : null
+        }
+      />
+    </Modal>
+  );
+};
+
+export default PasswordModal;
diff --git a/src/util/certificate.tsx b/src/util/certificate.tsx
index 02bd88e88b..337f0308e7 100644
--- a/src/util/certificate.tsx
+++ b/src/util/certificate.tsx
@@ -25,7 +25,7 @@ const details = [
   },
 ];
 
-export const generateCert = () => {
+export const generateCert = (password: string) => {
   const validDays = 1000;
 
   const keys = forge.pki.rsa.generateKeyPair(2048);
@@ -44,7 +44,7 @@ export const generateCert = () => {
 
   const crt = forge.pki.certificateToPem(cert);
 
-  const asn1 = forge.pkcs12.toPkcs12Asn1(keys.privateKey, [cert], "", {
+  const asn1 = forge.pkcs12.toPkcs12Asn1(keys.privateKey, [cert], password, {
     generateLocalKeyId: true,
     friendlyName: "LXD-UI",
   });