Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the asset upload of the maas-ui need the map #4249

Open
anthonydillon opened this issue Jul 15, 2022 · 2 comments
Open

Does the asset upload of the maas-ui need the map #4249

anthonydillon opened this issue Jul 15, 2022 · 2 comments

Comments

@anthonydillon
Copy link
Contributor

The majority of the size of the asset which is uploaded via the static asset project is the js map. Do we need to include that in for production builds?

@petermakowski
Copy link
Contributor

We don't have to include them, but they are very useful for debugging as they give us human-readable code even in production when you open Developer Tools.

They are also needed for Sentry logs to make sense. We could choose to upload source maps directly to sentry instead of hosting them publicly alongside the deployed code, but that would need to be setup.

https://docs.sentry.io/platforms/javascript/sourcemaps/

@amylily1011
Copy link
Contributor

This is blocked by Sentry upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants