Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MachineSelect to use ContextualMenu #4397

Open
petermakowski opened this issue Sep 8, 2022 · 3 comments
Open

Refactor MachineSelect to use ContextualMenu #4397

petermakowski opened this issue Sep 8, 2022 · 3 comments

Comments

@petermakowski
Copy link
Contributor

This component is looking a lot like how the ContextualMenu menu works, but with different classes: https://github.com/canonical/react-components/blob/main/src/components/ContextualMenu/ContextualMenu.tsx.

The contextual menu has a few things this doesn't, like using a portal (I saw a comment about using absolute positioning which the contextual menu dropdown supports), closing on esc etc.

A future task might be to make these two components share a common base.

Originally posted by @huwshimi in #4389 (comment)
@petermakowski petermakowski mentioned this issue Sep 8, 2022
Merged
@petermakowski
Copy link
Contributor Author

#4389 (comment)

@petermakowski
Copy link
Contributor Author

#4389 (comment)

@petermakowski
Copy link
Contributor Author

#4389 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petermakowski