Confusing UI - "Use secure erase" and "Use quick erase" are supposed to be subsidiary of "Erase nodes' disk"

[webteam-app]

Bug originally filed by nobuto at https://bugs.launchpad.net/bugs/2009669

maas: 1:3.3.0-13159-g.1c22f7beb-0ubuntu1~22.04.1
maas-ui: 3.3.0 acde9f1

In WebUI as MAAS/r/settings/storage, there is disk erase related configurations.

1. Erase nodes' disks prior to releasing (True/False)
2. Use secure erase by default when erasing disks (True/False)
3. Use quick erase by default when erasing disks (True/False)

Those 3 are presented equally at the same UI level in the WebUI. However,

2&3 do not take effect unless 1 is True, so it would be nice if

• 2&3 are grayed out if 1 is False.
• 2&3 are displayed at a subsidiary level of 1 in the UI (indented for example)

2&3 are mutually exclusive by design and MAAS doesn't not allow to release a node if both 2&3 are enabled so it would be nice if

• the fact that 2&3 are mutually exclusive is reflected in the UI (radio box or something)

[nobuto-m]

[nobuto-m]

2&3 are mutually exclusive by design and MAAS doesn't not allow to release a node if both 2&3 are enabled

I have a second thought on this. API operations actually allows both to be set. And the API client's help explains the behavior at least from a documentation point of view.

$ maas admin machine release -h
...

If both secure_erase and quick_erase are specified and the
drive does NOT have a secure erase feature, MAAS will behave as if only
quick_erase was specified.

So the mutually-exclusive behavior itself can be the bug in the UI.