[format] Ensure proper ending of the last line #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3913 +/- ##
=======================================
Coverage 89.10% 89.11%
=======================================
Files 255 255
Lines 14600 14600
=======================================
+ Hits 13010 13011 +1
+ Misses 1590 1589 -1 ☔ View full report in Codecov by Sentry. |
andrei-toterman
previously approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Yup, tested and it works as expected. Thanks, @ricab!
A question for the future: wouldn't it be nicer if the config options were sorted alphabetically?
|
It would indeed. I thought about it but resisted the perfectionism here for a change 😅 |
Addresses review request.
ricab
force-pushed
the
format-newline-at-eof
branch
from
5d611cf to
e607a6f
Compare
|
Not for long... I think that is it, but I wouldn't mind another set of eyes, as I just pieced it together with |
|
I wonder if we should place Language and Standard first in the section though, with a newline in between. |
Move the language and standard keys first in their section of the `clang-format` configuration, so they can sub/title it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR to ensure that we end files with a newline. See the POSIX definition of a line.