Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests are not detecting failures in the workload, leading to false ✔️ in CI #130

Open
ca-scribner opened this issue Jan 19, 2024 · 2 comments · May be fixed by #134
Open
Labels
bug Something isn't working

Comments

@ca-scribner
Copy link
Contributor

ca-scribner commented Jan 19, 2024

Bug Description

As described in #126, this charm's CI has been showing as working (eg: ✔️ ) even though the workload is not deploying properly. This led to us at some point in the past breaking the charm without noticing, and then catching it when it blocked a few unrelated efforts.

We should fix this CI, as well as any root causes for why it doesn't work (likely we need to address #82 as well, because sometimes the workload is up but not healthy).

To Reproduce

See #126.

Environment

Relevant Log Output

-

Additional Context

No response

@ca-scribner ca-scribner added the bug Something isn't working label Jan 19, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5229.

This message was autogenerated

@orfeas-k orfeas-k linked a pull request Feb 15, 2024 that will close this issue
@orfeas-k
Copy link
Contributor

orfeas-k commented Feb 15, 2024

In order to test the health check described in #82 (comment), implement the following logic:

  1. misconfigure the workload in order for the service to not replying successfully and the workload health check to be failing
  2. Then either:
    i. Wait 40 seconds which are the seconds that the health needs to be set to down (threshold * (period + timeout)). Then, fire an update-status in order to verify that the charm's status will reflect the workload's status
    ii. Configure model to fire update-status every 10 seconds using fast-forward and assert that the charm status is maintenace with a proper timeout. This can be done either like this or this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Labeled
Development

Successfully merging a pull request may close this issue.

2 participants