target.Location must always be set

canonical · Jun 30, 2023 · 8901224 · 8901224
1 parent bc85a35
commit 8901224
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/internals/plan/plan.go b/internals/plan/plan.go
@@ -780,7 +780,7 @@ func CombineLayers(layers ...*Layer) (*Layer, error) {
 			}
 		}
 
-		if target.Location == "" && len(target.Services) > 0 {
+		if target.Location == "" {
 			return nil, &FormatError{
 				Message: fmt.Sprintf(`plan must define "location" for log target %q`, name),
 			}

diff --git a/internals/plan/plan_test.go b/internals/plan/plan_test.go
@@ -932,6 +932,7 @@ var planTests = []planTest{{
 				override: merge
 			tgt2:
 				type: syslog
+				location: udp://1.2.3.4:514
 				services: []
 				override: replace
 			tgt3:
@@ -1007,6 +1008,7 @@ var planTests = []planTest{{
 			"tgt2": {
 				Name:     "tgt2",
 				Type:     plan.SyslogTarget,
+				Location: "udp://1.2.3.4:514",
 				Services: []string{},
 				Override: plan.ReplaceOverride,
 			},
@@ -1052,6 +1054,7 @@ var planTests = []planTest{{
 			"tgt2": {
 				Name:     "tgt2",
 				Type:     plan.SyslogTarget,
+				Location: "udp://1.2.3.4:514",
 				Override: plan.ReplaceOverride,
 			},
 			"tgt3": {