Flush() is no-op if no logs are buffered

canonical · Aug 2, 2023 · 8f820a6 · 8f820a6
1 parent 22a6968
commit 8f820a6
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/internals/overlord/logstate/loki.go b/internals/overlord/logstate/loki.go
@@ -67,6 +67,10 @@ func asLokiEntry(entry servicelog.Entry) lokiEntry {
 }
 
 func (c *lokiClient) Flush(ctx context.Context) error {
+	if c.numEntries() == 0 {
+		return nil // no-op
+	}
+
 	defer func() {
 		for svc := range c.entries {
 			c.entries[svc] = c.entries[svc][:0]