drain request body to allow connection reuse

canonical · Aug 4, 2023 · c3c8b45 · c3c8b45
1 parent c551a60
commit c3c8b45
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/internals/overlord/logstate/loki.go b/internals/overlord/logstate/loki.go
@@ -92,7 +92,12 @@ func (c *lokiClient) Flush(ctx context.Context) error {
 	if err != nil {
 		return err
 	}
-	defer func() { _ = resp.Body.Close() }()
+	defer func() {
+		// Drain request body to allow connection reuse
+		// see https://pkg.go.dev/net/http#Response.Body
+		_, _ = io.Copy(io.Discard, io.LimitReader(resp.Body, 1024*1024))
+		_ = resp.Body.Close()
+	}()
 
 	// Check response status code to see if it was successful
 	if code := resp.StatusCode; code < 200 || code >= 300 {