-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tests fail when executed as root as opposed to ubuntu #263
Comments
I'm not sure this is desired. In general we don't want to be running all the tests as root. There are some very specific tests we run as root to test user/group/permissions features, but it's not a good idea (and may be unsafe?) to run all tests as root. Thoughts? |
@shayancanonical Ping on the above. |
@benhoyt I agree, I wonder if it might be a good idea to skip tests that need to be run as non-root when the executing user is Similar to https://github.com/canonical/pebble/blob/master/internals/daemon/api_files_test.go#L537-L539 (except we would skip the tests if |
I'd be happy with a tweak like that (though I don't feel it's particularly needed). Feel free to add a PR, or tack it on to #262 if you want. |
Fixed by #262 |
Test output when running test as root:
Test output when run as ubuntu:
The text was updated successfully, but these errors were encountered: