-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent test failures: servstate.TestOnCheckFailure*
#270
Comments
This comment was marked as outdated.
This comment was marked as outdated.
@barrettj12 Sorry about this. I can see why the test has become even more timing sensitive. I will fix this test entirely asap. |
#272 Will now remove all remaining races from the on-check-failure unit tests (some other The issue was caused by part of the test behaviour more precisely (waiting for the |
@flotter synchronising on a channel seems like a good idea. Nonetheless, I am still observing intermittent failures in the following tests:
|
servstate.TestOnCheckFailureRestartWhileRunning
servstate.TestOnCheckFailure*
@barrettj12 I know what I have missed. For some reason my stress test did reveal my oversight. I will fix that asap, and because I missed that super obvious race, as punishment, fix a few more of them in servstate. |
Hehe, but don't feel bad, @flotter -- you're the only one of us fixing failures at the moment, the rest of us are just complaining about them! :-) |
Should be fixed by this: #283 |
Observing intermittent failures in the following tests:
TestOnCheckFailureRestartWhileRunning
TestOnCheckFailureIgnore
TestOnCheckFailureShutdown
The text was updated successfully, but these errors were encountered: