Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting is too slow #286

Closed
paul-rodriguez opened this issue Aug 23, 2023 · 3 comments
Closed

Linting is too slow #286

paul-rodriguez opened this issue Aug 23, 2023 · 3 comments

Comments

@paul-rodriguez
Copy link
Contributor

Side note, but I don't understand why on earth doing a bit of static checking on a small project like Pebble would take 5 minutes! That's ~300 billion clock cycles. Do we know which of the static checkers is the culprit / why it's slow?

Originally posted by @benhoyt in #273 (comment)

@flotter
Copy link
Contributor

flotter commented Aug 23, 2023

Just a note to others that currently this PR will fix this, when merged.

@benhoyt
Copy link
Contributor

benhoyt commented Aug 23, 2023

@flotter How will that PR fix the slowness? Isn't that just bumping up the golangci timeout to 5 minutes (from the default of 1 minute)?

@benhoyt
Copy link
Contributor

benhoyt commented Mar 13, 2024

Going to close this. Linting locally takes <1s (even with a clean golangci-lint cache), and it's taking about 20s in CI now. Which is still way longer than expected, but I don't thin it's worth looking into further at this point.

@benhoyt benhoyt closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants