Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stopRunningServices should probably also stop "starting" services #502

Closed
benhoyt opened this issue Sep 22, 2024 · 0 comments · Fixed by #503
Closed

stopRunningServices should probably also stop "starting" services #502

benhoyt opened this issue Sep 22, 2024 · 0 comments · Fixed by #503
Labels
25.04 Planned for the 25.04 cycle Simple Nice for a quick look on a minute or two

Comments

@benhoyt
Copy link
Contributor

benhoyt commented Sep 22, 2024

If the "startup: enabled" services are still starting (because it's been less than 1s) and you send SIGTERM to the Pebble daemon, it exits without trying to terminate or clean up those services, because servicesToStop only includes services in "running" and "backoff" state right now.

We should probably also include "starting" services. Let's just make sure there are no other bad implications of doing this.

See also #497 (comment)
@benhoyt benhoyt mentioned this issue Sep 22, 2024
Merged
@benhoyt benhoyt added 25.04 Planned for the 25.04 cycle Simple Nice for a quick look on a minute or two labels Sep 24, 2024
@IronCore864 IronCore864 mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
25.04 Planned for the 25.04 cycle Simple Nice for a quick look on a minute or two
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow stopping services in "starting" state IronCore864/pebble
1 participant
@benhoyt