Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: promote snap to candidate on every release #255

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

cjdcordeiro
Copy link
Collaborator

@cjdcordeiro cjdcordeiro commented Jul 6, 2023

closes #241

BEFORE MERGING: This new job requires a secret for letting Snapcraft authenticate with the Snap Store. I'm still in the process of getting a Pebble-specific bot account for this, so before merging, please double-check the current status with me so that I can also share said secret privately.

Context

This PR is built on top of #179, allowing us to automatically promote the Pebble snap to latest/candidate every time there is a new Pebble release on GitHub.

Summary of changes

  • this workflow is now also triggered on every GH release
  • during the snap tests, the Pebble client version is inferred so that it can be used for promoting the right snap version
  • on release, we wait for the Store to finish the snap builds for every architecture
  • once the store has built and released the respective snap into latest/edge, we then promote it to latest/candidate

Example of a successful build: https://github.com/cjdcordeiro/pebble/actions/runs/5475322209

@benhoyt benhoyt added the Blocked Waiting for something external label Jul 6, 2023
Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me, though I'm not the best person to review it (I don't have much knowledge of snapcraft and what's possible or not possible with it).

.github/workflows/snap.yml Show resolved Hide resolved
.github/workflows/snap.yml Show resolved Hide resolved
@cjdcordeiro cjdcordeiro removed the Blocked Waiting for something external label Jul 21, 2023
@cjdcordeiro
Copy link
Collaborator Author

@benhoyt @jnsgruk @niemeyer

Update:

We now have a bot account that we can use from within the GitHub workflows to login with the Snap store and promote the Pebble snap.

I have already shared the credentials with you.

Please add the SNAPCRAFT_STORE_CREDENTIALS secret to this repo and then the PR can be considered to be merged.

@cjdcordeiro cjdcordeiro requested a review from benhoyt July 21, 2023 08:46
@jnsgruk
Copy link
Member

jnsgruk commented Jul 25, 2023

Please add the SNAPCRAFT_STORE_CREDENTIALS secret to this repo and then the PR can be considered to be merged.

Done!

@jnsgruk jnsgruk merged commit b073926 into canonical:master Jul 31, 2023
16 checks passed
@cjdcordeiro cjdcordeiro deleted the ROCKS-673_auto-promote-snap branch August 2, 2023 06:19
@benhoyt benhoyt mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promote Pebble snap on every release
3 participants