enter: start default services before executing subcommand

internals/cli/cmd_enter_test.go

@@ -9,6 +9,7 @@ import (
 	"path/filepath"
 	"strings"
 	"text/template"
+	"time"
 
 	. "gopkg.in/check.v1"
 
@@ -231,3 +232,40 @@ func (s *PebbleSuite) TestEnterHelpCommandHelpArg(c *C) {
 	c.Check(stdout, Matches, "(?s).*\\bThe help command displays information about commands\\..*")
 	c.Check(exitCode, Equals, 0)
 }
+
+// TestEnterSubCommandWaits checks that the subcommand in enter
+// starts **after** the default services have started. It utilizes
+// the modification time of /proc/[PID] directory for checking.
+func (s *PebbleSuite) TestEnterSubCommandWaits(c *C) {
+	layerTemplate := dumbDedent(`
+		services:
+		  stat:
+		    override: replace
+		    command: /bin/sh -c 'stat -c "%y" /proc/$$ > $PEBBLE/stat; sleep 1;'
+		    startup: enabled
+	`)
+	layerPath := filepath.Join(s.pebbleDir, "layers", "001-stat.yaml")
+	writeTemplate(layerPath, layerTemplate, nil)
+
+	cmd := []string{"pebble", "enter", "--run", "exec", "/bin/sh", "-c", "stat -c '%y' /proc/$$"}
+	restore := fakeArgs(cmd...)
+	defer restore()
+
+	exitCode := cli.PebbleMain()
+	c.Check(exitCode, Equals, 0)
+	// stderr is written to stdout buffer because of "combine stderr" mode,
+	// see cmd/pebble/cmd_exec.go:163
+	c.Check(s.Stderr(), Equals, "")
+	stdout := s.Stdout()
+
+	layout := "2006-01-02 15:04:05.000000000 -0700"
+	subCmdExecTime, err := time.Parse(layout, strings.TrimSpace(stdout))
+	c.Check(err, IsNil)
+
+	svcOut, err := ioutil.ReadFile(filepath.Join(s.pebbleDir, "stat"))
+	c.Check(err, IsNil)
+	svcStartTime, err := time.Parse(layout, strings.TrimSpace(string(svcOut)))
+	c.Check(err, IsNil)
+
+	c.Check(svcStartTime.Before(subCmdExecTime), Equals, true)
+}

internals/cli/cmd_run.go

@@ -90,7 +90,7 @@ func (rcmd *cmdRun) run(ready chan<- func()) {
 			// This exit code must be in system'd SuccessExitStatus.
 			panic(&exitStatus{42})
 		}
-		fmt.Fprintf(os.Stderr, "cannot run pebble: %v\n", err)
+		fmt.Fprintf(Stderr, "cannot run pebble: %v\n", err)
 		panic(&exitStatus{1})
 	}
 }
@@ -194,6 +194,15 @@ func runDaemon(rcmd *cmdRun, ch chan os.Signal, ready chan<- func()) error {
 
 	logger.Debugf("activation done in %v", time.Now().Truncate(time.Millisecond).Sub(t0))
 
+	var autoStartReady chan error
+	var stop chan struct{}
+
+	notifyReady := func() {
+		stop = make(chan struct{}, 1)
+		ready <- func() { close(stop) }
+		close(ready)
+	}
+
 	if !rcmd.Hold {
 		servopts := client.ServiceOptions{}
 		changeID, err := rcmd.client.AutoStart(&servopts)
@@ -202,13 +211,21 @@ func runDaemon(rcmd *cmdRun, ch chan os.Signal, ready chan<- func()) error {
 		} else {
 			logger.Noticef("Started default services with change %s.", changeID)
 		}
-	}
 
-	var stop chan struct{}
-	if ready != nil {
-		stop = make(chan struct{}, 1)
-		ready <- func() { close(stop) }
-		close(ready)
+		if ready != nil {
+			// wait for the default services to start
+			autoStartReady = make(chan error, 1)
+			go func() {
+				waitCmd := waitMixin{
+					hideProgress: true,
+				}
+				waitCmd.setClient(rcmd.client)
+				_, err := waitCmd.wait(changeID)
+				autoStartReady <- err
+			}()
+		}
+	} else if ready != nil {
+		notifyReady()
 	}
 
 out:
@@ -226,6 +243,11 @@ out:
 				d.SetDegradedMode(nil)
 				tic.Stop()
 			}
+		case chgErr := <-autoStartReady:
+			if chgErr != nil {
+				logger.Noticef("Error starting default services: %v", chgErr)
+			}
+			notifyReady()
 		case <-stop:
 			break out
 		}

internals/cli/wait.go

@@ -32,8 +32,9 @@ var (
 
 type waitMixin struct {
 	clientMixin
-	NoWait    bool `long:"no-wait"`
-	skipAbort bool
+	NoWait       bool `long:"no-wait"`
+	skipAbort    bool
+	hideProgress bool
 }
 
 var waitDescs = map[string]string{
@@ -64,7 +65,12 @@ func (wmx waitMixin) wait(id string) (*client.Change, error) {
 		}
 	}()
 
-	pb := progress.MakeProgressBar()
+	var pb progress.Meter
+	if wmx.hideProgress {
+		pb = progress.NullMeter{}
+	} else {
+		pb = progress.MakeProgressBar()
+	}
 	defer func() {
 		pb.Finished()
 		// Next two are not strictly needed for CLI, but