Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logfwd): support forwarding logs to Loki #267

Merged
merged 39 commits into from
Sep 25, 2023
Merged

feat(logfwd): support forwarding logs to Loki #267

merged 39 commits into from
Sep 25, 2023

Commits on Aug 28, 2023

  1. Implement Loki client

    @barrettj12
    barrettj12 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f56d4ad View commit details
    Browse the repository at this point in the history

  2. update README

    @barrettj12
    barrettj12 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8ff49d8 View commit details
    Browse the repository at this point in the history

  3. don't need to allocate for errors.As

    @barrettj12
    barrettj12 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    72942ad View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. remove clienterr package

    @barrettj12
    barrettj12 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e91b3d9 View commit details
    Browse the repository at this point in the history

  2. don't drop logs on 429 / 5xx 

    - warn user when dropping logs
    @barrettj12
    barrettj12 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4d8e66f View commit details
    Browse the repository at this point in the history

  3. remove retryAfter from loki.Client 

    - use channel to synchronise server in loki test
    @barrettj12
    barrettj12 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a702d37 View commit details
    Browse the repository at this point in the history

  4. revert changes to .golangci.yml

    @barrettj12
    barrettj12 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a8b0c3e View commit details
    Browse the repository at this point in the history

  5. rename gatherer timer -> flushTimer

    @barrettj12
    barrettj12 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2c427e4 View commit details
    Browse the repository at this point in the history

  6. rename SetRequestTimeout -> FakeRequestTimeout

    @barrettj12
    barrettj12 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2d62565 View commit details
    Browse the repository at this point in the history

  7. [README] better names for example targets

    @barrettj12
    barrettj12 committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    8a77df6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. empty buffer inside handleServerResponse

    @barrettj12
    barrettj12 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0af606a View commit details
    Browse the repository at this point in the history

  2. fix errFromResponse

    @barrettj12
    barrettj12 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    7e00ccd View commit details
    Browse the repository at this point in the history

  3. elaborate on retry comments

    @barrettj12
    barrettj12 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5d21565 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. address Gustavo's review comments 

    - emptyBuffer -> resetBuffer
- request -> lokiRequest
- stream -> lokiStream
- remove unnecessary whitespace from inline JSON
    @barrettj12
    barrettj12 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2b78abe View commit details
    Browse the repository at this point in the history

  2. rejig loki error handling 

    - send response body to debug logs
    @barrettj12
    barrettj12 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0142e7e View commit details
    Browse the repository at this point in the history

  3. if-else for debug logging error

    @barrettj12
    barrettj12 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    79187af View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. success is only 200 or 204

    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1c694b3 View commit details
    Browse the repository at this point in the history

  2. pull log-counting / flushing logic into gatherer 

    - modify logClient interface
    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0ea5f34 View commit details
    Browse the repository at this point in the history

  3. store entries in slice 

    - allows easy truncation
    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f7ef7ff View commit details
    Browse the repository at this point in the history

  4. fix up the tests 

    - allow overriding maxBufferedEntries in test
    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f9fea04 View commit details
    Browse the repository at this point in the history

  5. rename AddLog to Add

    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    892c037 View commit details
    Browse the repository at this point in the history

  6. continue stmt after flush 

    - some minor naming/comment improvements
    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bce2a86 View commit details
    Browse the repository at this point in the history

  7. count # of written logs in gatherer 

    - remove NumBuffered method
    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2dbbfb6 View commit details
    Browse the repository at this point in the history

  8. reallocate buffer periodically to avoid memory leaks

    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9b72978 View commit details
    Browse the repository at this point in the history

  9. add test for retry/truncate logic

    @barrettj12
    barrettj12 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fabf8a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. fix gathererSuite.TestRetryLoki 

    - introduce loki.ClientArgs
- remove loki testing patch functions
    @barrettj12
    barrettj12 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1c0ed80 View commit details
    Browse the repository at this point in the history

  2. fix imports

    @barrettj12
    barrettj12 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8ea3930 View commit details
    Browse the repository at this point in the history

  3. increase timeouts to improve test reliability

    @barrettj12
    barrettj12 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6a733c0 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary comment

    @barrettj12
    barrettj12 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3c6e172 View commit details
    Browse the repository at this point in the history

  5. bump test timeouts to 1 sec

    @barrettj12
    barrettj12 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4dab1dd View commit details
    Browse the repository at this point in the history

  6. use json.Compact in tests

    @barrettj12
    barrettj12 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    084544b View commit details
    Browse the repository at this point in the history

  7. loki test: handler doesn't need to be pointer

    @barrettj12
    barrettj12 committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a5ab88c View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Address Gustavo's review comments 

    - ClientArgs -> options *ClientOptions
- rename N -> n
- explicitly reallocate buffer when full
    @barrettj12
    barrettj12 committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c4e153c View commit details
    Browse the repository at this point in the history

  2. Rename logGathererArgs -> *logGathererOptions

    @barrettj12
    barrettj12 committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    164f9ad View commit details
    Browse the repository at this point in the history

  3. tweak 4xx comment

    @barrettj12
    barrettj12 committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c6b27b0 View commit details
    Browse the repository at this point in the history

  4. when truncating, zero the element to allow GC

    @barrettj12
    barrettj12 committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e80cfcd View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. reuse same buffer instead of reallocating

    @barrettj12
    barrettj12 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    159bbe9 View commit details
    Browse the repository at this point in the history

  2. add test for buffer recycling

    @barrettj12
    barrettj12 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a94d8ff View commit details
    Browse the repository at this point in the history

  3. Address Ben's comments on testing 

    - inline checkBuffer
- coerce to string w/o check
    @barrettj12
    barrettj12 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    20c76b2 View commit details
    Browse the repository at this point in the history