Support for Pebble Notices #288
Conversation
| notice.repeatAfter = repeatAfter | ||
|
|
||
| if newOrRepeated { | ||
| s.processNoticeWaiters() |
There was a problem hiding this comment.
it feels a bit dangerous that this can potential block on unrelated code and timeouts decided by it, it would a bit more complex but safer to have in-between goroutines that distribute things to waiters
There was a problem hiding this comment.
The idea here is that processNoticeWaiters can't block, because it only sends to the current noticeWaiters channels, and those are added and removed with each call to WaitNotice (the other goroutines). And we have a done (ctx.Done()) channel on each send too, to avoid blocking if the context is cancelled.
The addNoticeWaiter / removeNoticeWaiter / processNoticeWaiters logic is intentionally very close together in that file, partly for that reason.
So I'm not sure how adding additional in-between goroutines will help here?
|
Closing this draft in favour of the real PRs, starting with #295 (other PRs linked there). |
Just a WIP draft at the mojment.
See the spec: JU048.