[MISC] Setting profiles (#157)

* Setting profiles

* Bump libs

Author: dragomirp

lib/charms/data_platform_libs/v0/data_interfaces.py

@@ -320,7 +320,7 @@ def _on_topic_requested(self, event: TopicRequestedEvent):
 
 # Increment this PATCH version before using `charmcraft publish-lib` or reset
 # to 0 if you are raising the major API version
-LIBPATCH = 19
+LIBPATCH = 20
 
 PYDEPS = ["ops>=2.0.0"]
 
@@ -1674,6 +1674,10 @@ def _assign_relation_alias(self, relation_id: int) -> None:
         if relation:
             relation.data[self.local_unit].update({"alias": available_aliases[0]})
 
+        # We need to set relation alias also on the application level so,
+        # it will be accessible in show-unit juju command, executed for a consumer application unit
+        self.update_relation_data(relation_id, {"alias": available_aliases[0]})
+
     def _emit_aliased_event(self, event: RelationChangedEvent, event_name: str) -> None:
         """Emit an aliased event to a particular relation if it has an alias.
 

lib/charms/data_platform_libs/v0/upgrade.py

@@ -285,7 +285,7 @@ def restart(self, event) -> None:
 
 # Increment this PATCH version before using `charmcraft publish-lib` or reset
 # to 0 if you are raising the major API version
-LIBPATCH = 13
+LIBPATCH = 14
 
 PYDEPS = ["pydantic>=1.10,<2", "poetry-core"]
 
@@ -895,6 +895,10 @@ def _on_upgrade_charm(self, event: UpgradeCharmEvent) -> None:
             self.charm.unit.status = WaitingStatus("other units upgrading first...")
             self.peer_relation.data[self.charm.unit].update({"state": "ready"})
 
+            if self.charm.app.planned_units() == 1:
+                # single unit upgrade, emit upgrade_granted event right away
+                getattr(self.on, "upgrade_granted").emit()
+
         else:
             # for k8s run version checks only on highest ordinal unit
             if (

lib/charms/postgresql_k8s/v0/postgresql.py

@@ -19,7 +19,7 @@
 Any charm using this library should import the `psycopg2` or `psycopg2-binary` dependency.
 """
 import logging
-from typing import List, Optional, Set, Tuple
+from typing import Dict, List, Optional, Set, Tuple
 
 import psycopg2
 from psycopg2 import sql
@@ -32,7 +32,7 @@
 
 # Increment this PATCH version before using `charmcraft publish-lib` or reset
 # to 0 if you are raising the major API version
-LIBPATCH = 14
+LIBPATCH = 17
 
 INVALID_EXTRA_USER_ROLE_BLOCKING_MESSAGE = "invalid role(s) for extra user roles"
 
@@ -117,12 +117,13 @@ def _connect_to_database(
         connection.autocommit = True
         return connection
 
-    def create_database(self, database: str, user: str) -> None:
+    def create_database(self, database: str, user: str, plugins: List[str] = []) -> None:
         """Creates a new database and grant privileges to a user on it.
 
         Args:
             database: database to be created.
             user: user that will have access to the database.
+            plugins: extensions to enable in the new database.
         """
         try:
             connection = self._connect_to_database()
@@ -170,6 +171,10 @@ def create_database(self, database: str, user: str) -> None:
             logger.error(f"Failed to create database: {e}")
             raise PostgreSQLCreateDatabaseError()
 
+        # Enable preset extensions
+        for plugin in plugins:
+            self.enable_disable_extension(plugin, True, database)
+
     def create_user(
         self, user: str, password: str = None, admin: bool = False, extra_user_roles: str = None
     ) -> None:
@@ -406,6 +411,7 @@ def update_user_password(self, username: str, password: str) -> None:
         Raises:
             PostgreSQLUpdateUserPasswordError if the password couldn't be changed.
         """
+        connection = None
         try:
             with self._connect_to_database() as connection, connection.cursor() as cursor:
                 cursor.execute(
@@ -420,19 +426,39 @@ def update_user_password(self, username: str, password: str) -> None:
             if connection is not None:
                 connection.close()
 
+    def is_restart_pending(self) -> bool:
+        """Query pg_settings for pending restart."""
+        connection = None
+        try:
+            with self._connect_to_database() as connection, connection.cursor() as cursor:
+                cursor.execute("SELECT COUNT(*) FROM pg_settings WHERE pending_restart=True;")
+                return cursor.fetchone()[0] > 0
+        except psycopg2.OperationalError:
+            logger.warning("Failed to connect to PostgreSQL.")
+            return False
+        except psycopg2.Error as e:
+            logger.error(f"Failed to check if restart is pending: {e}")
+            return False
+        finally:
+            if connection:
+                connection.close()
+
     @staticmethod
     def build_postgresql_parameters(
-        profile: str, available_memory: int
-    ) -> Optional[dict[str, str]]:
+        profile: str, available_memory: int, limit_memory: Optional[int] = None
+    ) -> Optional[Dict[str, str]]:
         """Builds the PostgreSQL parameters.
 
         Args:
             profile: the profile to use.
             available_memory: available memory to use in calculation in bytes.
+            limit_memory: (optional) limit memory to use in calculation in bytes.
 
         Returns:
             Dictionary with the PostgreSQL parameters.
         """
+        if limit_memory:
+            available_memory = min(available_memory, limit_memory)
         logger.debug(f"Building PostgreSQL parameters for {profile=} and {available_memory=}")
         if profile == "production":
             # Use 25% of the available memory for shared_buffers.
@@ -446,3 +472,6 @@ def build_postgresql_parameters(
             }
 
             return parameters
+        else:
+            # Return default
+            return {"shared_buffers": "128MB"}

tests/integration/relations/pgbouncer_provider/test_pgbouncer_provider.py

@@ -81,6 +81,7 @@ async def test_database_relation_with_charm_libraries(ops_test: OpsTest, pgb_cha
             num_units=2,
             channel="14/edge",
             trust=True,
+            config={"profile": "testing"},
         ),
     )
     await ops_test.model.add_relation(f"{PGB}:{BACKEND_RELATION_NAME}", f"{PG}:database")

tests/integration/relations/test_backend_database.py

@@ -55,7 +55,9 @@ async def test_relate_pgbouncer_to_postgres(ops_test: OpsTest, pgb_charm):
                 trust=True,
             ),
             # Edge 5 is the new postgres charm
-            ops_test.model.deploy(PG, channel="14/edge", trust=True, num_units=3),
+            ops_test.model.deploy(
+                PG, channel="14/edge", trust=True, num_units=3, config={"profile": "testing"}
+            ),
         )
         await asyncio.gather(
             ops_test.model.wait_for_idle(apps=[PGB], status="blocked", timeout=1000),

tests/integration/relations/test_db.py

@@ -52,7 +52,9 @@ async def test_create_db_legacy_relation(ops_test: OpsTest, pgb_charm):
                 series=CHARM_SERIES,
                 trust=True,
             ),
-            ops_test.model.deploy(PG, num_units=3, trust=True, channel="14/edge"),
+            ops_test.model.deploy(
+                PG, num_units=3, trust=True, channel="14/edge", config={"profile": "testing"}
+            ),
             ops_test.model.deploy("finos-waltz-k8s", application_name=FINOS_WALTZ, channel="edge"),
         )
 

tests/integration/relations/test_db_admin.py

@@ -45,7 +45,9 @@ async def test_create_db_admin_legacy_relation(ops_test: OpsTest, pgb_charm):
                 series=CHARM_SERIES,
                 trust=True,
             ),
-            ops_test.model.deploy(PG, trust=True, num_units=3, channel="14/edge"),
+            ops_test.model.deploy(
+                PG, trust=True, num_units=3, channel="14/edge", config={"profile": "testing"}
+            ),
             ops_test.model.deploy(
                 FIRST_DISCOURSE_APP_NAME, application_name=FIRST_DISCOURSE_APP_NAME
             ),

tests/integration/relations/test_peers.py

@@ -53,7 +53,9 @@ async def test_scaled_relations(ops_test: OpsTest):
     async with ops_test.fast_forward():
         await asyncio.gather(
             # Edge 5 is the new postgres charm
-            ops_test.model.deploy(PG, channel="14/edge", trust=True, num_units=3),
+            ops_test.model.deploy(
+                PG, channel="14/edge", trust=True, num_units=3, config={"profile": "testing"}
+            ),
             ops_test.model.deploy("finos-waltz-k8s", application_name=FINOS_WALTZ, channel="edge"),
         )
 

tests/integration/test_tls.py

@@ -72,7 +72,11 @@ async def test_build_and_deploy(ops_test: OpsTest, pgb_charm):
         wait_for_apps = True
         # Deploy Postgresql operator
         await ops_test.model.deploy(
-            POSTGRESQL_APP_NAME, channel="14/edge", trust=True, num_units=DATABASE_UNITS
+            POSTGRESQL_APP_NAME,
+            channel="14/edge",
+            trust=True,
+            num_units=DATABASE_UNITS,
+            config={"profile": "testing"},
         )
         await ops_test.model.relate(PGB, POSTGRESQL_APP_NAME)
 

tests/integration/test_upgrade.py

@@ -57,6 +57,7 @@ async def test_in_place_upgrade(ops_test: OpsTest, pgb_charm):
             num_units=2,
             channel="14/edge",
             trust=True,
+            config={"profile": "testing"},
         ),
     )
     await ops_test.model.add_relation(f"{PGB}:{BACKEND_RELATION_NAME}", f"{PG}:database")