Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for working-dir in the service schema #305

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

cjdcordeiro
Copy link
Collaborator

  • Have you signed the CLA?

Closes #303.

It is now possible to set a working directory for Pebble services: canonical/pebble@a807026

This PR adds support for the new field in rockcraft.yaml

Copy link
Contributor

@SamirPS SamirPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to update this branch with main branch

@cjdcordeiro cjdcordeiro requested a review from tigarmo June 30, 2023 07:14
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

@tigarmo tigarmo merged commit 4594740 into canonical:main Jul 3, 2023
14 checks passed
cjdcordeiro added a commit to cjdcordeiro/rockcraft that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add working-dir to to service schema
4 participants