Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bank account screen #494

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Alfredoeb9
Copy link
Contributor

Fixes: #452

This PR implements the new feature to allow users to create, read, update and delete bank accounts.

Build test has passed.

created delete api to delete respected bank account
created and implemented bank account table to display any bank accounts created
created bank account modal and implemented input fields based on respected prisma bank account schema
created bank account create api to take in values from input fields and send data to db into bankAccount table and implemented audit function
updated delete feature content to reflect bank account action
updated bank account notification, onSuccesseful deletion will return  server message with toast message
updated bank account delete and create api to return a message on 200 return
updated created api with try catch block with custom error when @@unique runs
updated bank account modal notification to catch custom @@unique from server
created edit bank account functionality to allow user to update information for respected bank acccount
created new edit bank account modal to separate original create bank account modal
updated audit schema to include update when user successfully updates an account
created update api to update bank account based on id
updated primary account logic to show confirm diaglog box which if then user confirm, this allows
the user to switch primary account and if cancelled, switch button is still disabled until confirmed
removed @@unique constraint on primary column as this would result in error when trying to switch account false -> true
and true -> false
created migration on prisma db to remove @@unique constraints on companyId and primary to allow
auto switch on primary accounts from false -> true and true -> false
updated edit bank account feature to allow user to edit any info needed and updated respected
account based on field clicked and taking care of if user is switching primary accounts
running a findFirst on both primary and nonPrimary and if new bankAccount being created is with wanted primary account and findFirst query returns true as well then error is passed down and bank account is not created but if there is not then bank account can be created
when user successfully creates bank account modal disappears and user is shown newly created accounts
Copy link

Thank you for following the naming conventions for pull request titles! 🙏

@Alfredoeb9
Copy link
Contributor Author

Alfredoeb9 commented Aug 22, 2024

Note: After merging main into this Alfredoeb9:add_bank_account_screen I'm seeing error on ./src/emails/AccountVerificationEmail.tsx

image

Steps Taken: I then checked out main branch without my changes on this PR branch and seeing same errors as above. I can confirm errors on screenshot are not coming from Alfredoeb9:add_bank_account_screen but have to be coming from a different PR that was merged in prior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bank accounts modal and table
1 participant