Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying both start and end date for transaction downloads #42

Open
501st-alpha1 opened this issue May 24, 2017 · 0 comments
Open

Comments

@501st-alpha1
Copy link

Currently the only way to change the time period of downloaded transactions is to use the --download-days argument, which specifies how many days before today to start downloading transactions. I would like to be able to specify both a start and an end date for the transactions to download. E.g.: I might want to download my transactions for the previous month, but didn't get around to it until the 5th, so I need a way to exclude the transactions that occurred in the past 5 days.

I have a solution that I hacked together that "works", but I'd like some advice before I turn it into a PR. Would you prefer that I extend the current functionality, adding an argument to specify how many days to exclude? Or should I add new arguments that allow the user to specify a start and an end date instead? For a scenario like I described above, the latter might be better, so that I wouldn't have to calculate how many days I need to use for each argument. Alternatively, should we support both types of arguments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant